Skip to content

test: Add more test cases to validate model name - #8701

Merged
mudit-eng merged 1 commit into
mainfrom
mudita/tri-824-2603-l0_mlflow-base
Mar 16, 2026
Merged

test: Add more test cases to validate model name#8701
mudit-eng merged 1 commit into
mainfrom
mudita/tri-824-2603-l0_mlflow-base

Conversation

@mudit-eng

Copy link
Copy Markdown
Contributor

What does the PR do?

This PR adds more test cases to validate model name while loading.

  1. Test cover cases " .." and ".. ". Remove leading and trailing whitespace from model name before checking for path traversal characters.
  2. Names with dots like "model..", "...", "..model" are valid according to the POSIX standard. Test checks those

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Changes in core: triton-inference-server/core#481

Where should the reviewer start?

Look at changes in core: triton-inference-server/core#481

Test plan:

Added test cases and verified they pass by running locally

  • CI Pipeline ID:
    46042638
    (MLFlow passed, have to retry Input Validation as it failed due to different reason)

@mudit-eng mudit-eng added PR: test Adding missing tests or correcting existing test fix labels Mar 13, 2026
@mudit-eng mudit-eng changed the title fix: Add more test cases to validate model name test: Add more test cases to validate model name Mar 13, 2026

@pskiran1 pskiran1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mudit-eng
mudit-eng merged commit da9028a into main Mar 16, 2026
3 checks passed
@mudit-eng
mudit-eng deleted the mudita/tri-824-2603-l0_mlflow-base branch March 16, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

4 participants