Skip to content

test: Add more test cases to validate model name #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudit-eng merged 1 commit into from
Mar 16, 2026
+24 −10
Merged

test: Add more test cases to validate model name #8701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions qa/L0_input_validation/input_validation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ class ModelNameValidationTest(unittest.TestCase):
def test_model_name_invalid_load(self):
client = tritongrpcclient.InferenceServerClient("localhost:8001")
for model_name in self.INVALID_TRAVERSAL_NAMES:
print(f"Testing model name: {model_name!r}")
with self.assertRaises(InferenceServerException) as cm:
client.load_model(model_name)
self.assertIn(
Expand All @@ -318,7 +319,10 @@ def test_model_name_empty_load(self):
client = tritongrpcclient.InferenceServerClient("localhost:8001")
with self.assertRaises(InferenceServerException) as cm:
client.load_model("")
self.assertIn("model name must not be empty", str(cm.exception))
self.assertIn(
"Model name cannot be empty. Please enter a valid name to deploy.",
str(cm.exception),
)

def test_model_name_whitespace_only_load(self):
client = tritongrpcclient.InferenceServerClient("localhost:8001")
Expand All @@ -327,7 +331,7 @@ def test_model_name_whitespace_only_load(self):
with self.assertRaises(InferenceServerException) as cm:
client.load_model(model_name)
self.assertIn(
"model name must not contain only whitespace",
"Model name cannot be empty. Please enter a valid name to deploy.",
str(cm.exception),
f"Expected whitespace-only rejection for model name: {model_name!r}",
)
Expand All @@ -348,15 +352,25 @@ def test_model_name_invalid_unload(self):
def test_model_name_valid(self):
"""Verify that a syntactically valid model name is not rejected by
the traversal check -- it should fail with a model not found error instead."""
VALID_MODEL_NAMES = [
"model123",
# "model OAI", TRI-769: Fix this test case
"model.version1",
"...",
"..my_model",
"model..1",
"model....1",
]
client = tritongrpcclient.InferenceServerClient("localhost:8001")
with self.assertRaises(InferenceServerException) as cm:
client.load_model("nonexistent_model")
self.assertNotIn(
"path traversal characters",
str(cm.exception),
"Valid model name should not trigger path traversal rejection",
)
self.assertIn("failed to poll from model repository", str(cm.exception))
for model_name in VALID_MODEL_NAMES:
with self.assertRaises(InferenceServerException) as cm:
client.load_model(model_name)
self.assertNotIn(
"path traversal characters",
str(cm.exception),
"Valid model name should not trigger path traversal rejection",
)
self.assertIn("failed to poll from model repository", str(cm.exception))


if __name__ == "__main__":
Expand Down
Loading