Skip to content

test: Update L0_openai TRT-LLM model repository preparation - #8717

Merged
pskiran1 merged 9 commits into
mainfrom
spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
Apr 11, 2026
Merged

test: Update L0_openai TRT-LLM model repository preparation#8717
pskiran1 merged 9 commits into
mainfrom
spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation

Conversation

@pskiran1

@pskiran1 pskiran1 commented Mar 30, 2026

Copy link
Copy Markdown
Member

What does the PR do?

Updates the qa/L0_openai TRT-LLM test setup to remove hard-coded version for downloading TRT-LLM backend models, which was introduced in the https://github.com/triton-inference-server/server/pull/8510/changes#diff-811fb0863c7b3d9caae9db6721260d3a26b3c8ea9c48a24cb2728aa86da928c9.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 48006607

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
@pskiran1 pskiran1 added the PR: test Adding missing tests or correcting existing test label Mar 30, 2026
@pskiran1
pskiran1 requested a review from Copilot March 30, 2026 12:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the qa/L0_openai TRT-LLM test setup to rely on a pre-existing TRT-LLM model repository skeleton inside the container, rather than cloning TensorRT-LLM during the test run.

Changes:

  • Removed the helper that cloned TensorRT-LLM to obtain triton_backend/all_models.
  • Updated TRT-LLM preparation to copy the inflight batcher model repository from a container path (/app/all_models/...).
  • Simplified prepare_tensorrtllm invocation by dropping the TensorRT-LLM repo directory argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread qa/L0_openai/test.sh
 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
@pskiran1
pskiran1 marked this pull request as ready for review April 2, 2026 18:29
@pskiran1
pskiran1 requested review from whoisj and yinggeh April 2, 2026 18:30
@yinggeh

yinggeh commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Not sure how /app/all_models is prepared. Isn't it better to clones from Triton forked repository https://github.com/triton-inference-server/tensorrtllm_backend? So that when the test breaks due to out-dated models, we can update our local repo and verify in the CI.

Comment thread qa/L0_openai/test.sh Outdated
@pskiran1
pskiran1 marked this pull request as draft April 7, 2026 16:57
pskiran1 added 4 commits April 7, 2026 22:27
 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
 into spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation
@pskiran1
pskiran1 marked this pull request as ready for review April 8, 2026 11:37
@pskiran1
pskiran1 requested a review from mc-nv April 8, 2026 12:49
@yinggeh

yinggeh commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

LGTM. Would like to get @mc-nv approval before merging

@pskiran1
pskiran1 merged commit 399a795 into main Apr 11, 2026
3 checks passed
@pskiran1
pskiran1 deleted the spolisetty/tri-308-update-l0_openai-trt-llm-model-repository-preparation branch April 11, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

5 participants