-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test: Add test case for RequestTracker counter mismatch #8722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattwittwer
merged 5 commits into
main
from
mwittwer/ensemble-schedule-steps-counter-cleanup
Apr 14, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1655e56
Add test cases
mattwittwer dfeafda
update testing layout
mattwittwer 6ef2d23
Actually resolve merge conflicts
mattwittwer f394165
Merge branch 'main' into mwittwer/ensemble-schedule-steps-counter-cle…
mattwittwer cdda7ef
Merge branch 'main' into mwittwer/ensemble-schedule-steps-counter-cle…
mattwittwer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Copyright 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # Redistribution and use in source and binary forms, with or without | ||
| # modification, are permitted provided that the following conditions | ||
| # are met: | ||
| # * Redistributions of source code must retain the above copyright | ||
| # notice, this list of conditions and the following disclaimer. | ||
| # * Redistributions in binary form must reproduce the above copyright | ||
| # notice, this list of conditions and the following disclaimer in the | ||
| # documentation and/or other materials provided with the distribution. | ||
| # * Neither the name of NVIDIA CORPORATION nor the names of its | ||
| # contributors may be used to endorse or promote products derived | ||
| # from this software without specific prior written permission. | ||
| # | ||
| # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY | ||
| # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| # IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
| # PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
| # CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
| # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
| # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
| # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | ||
| # OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| name: "join_add_sub" | ||
| backend: "python" | ||
| max_batch_size: 1 | ||
|
|
||
| input [ | ||
| { | ||
| name: "INPUT0" | ||
| data_type: TYPE_FP32 | ||
| dims: [ 1 ] | ||
| } | ||
| ] | ||
| input [ | ||
| { | ||
| name: "INPUT1" | ||
| data_type: TYPE_FP32 | ||
| dims: [ 1 ] | ||
| } | ||
| ] | ||
| output [ | ||
| { | ||
| name: "OUTPUT0" | ||
| data_type: TYPE_FP32 | ||
| dims: [ 1 ] | ||
| } | ||
| ] | ||
| output [ | ||
| { | ||
| name: "OUTPUT1" | ||
| data_type: TYPE_FP32 | ||
| dims: [ 1 ] | ||
| } | ||
| ] | ||
|
|
||
| instance_group [{ kind: KIND_CPU }] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test never asserts that at least one successful response is returned before the queue-full error. As written, it can pass even if the enqueue failure happens early enough that zero responses are produced, which wouldn’t validate the regression expectation (“responses completed before the failure are still valid”). Consider asserting len(responses) > 0 (or >= 1) before checking their contents, so the test truly exercises the partial-success path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, I agree the current test does not guarantee at least one successful response, and that is largely by design in this case.
The main purpose of this test is to exercise the parallel failed-enqueue path and verify it does not crash the server. That is covered by the existing assertions around the expected queue-full error in the client plus the server-liveness check in
test.shafter the request completes.Adding a check for at least one successful output would change the test. Since we already have other tests that validate successful output behavior in the non-error case, I’d prefer to keep this one focused on the no-crash regression.