Remove Windows server build support - #8812
Merged
Merged
Conversation
Drop the Windows-specific server build paths so the build tooling and CMake configuration follow the supported Unix-style flow, and fail fast when Windows is requested as a target platform.
whoisj
reviewed
Jun 2, 2026
whoisj
left a comment
whoisj
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Had 1 question.
The --container-memory CLI option was only consumed by the Windows docker build code paths, which were removed in the previous commit. The argument was left orphaned: accepted on the CLI but never read, which silently misleads users into thinking they had set a memory limit. Drop it now that no code path uses it. Addresses review feedback on PR #8812.
Update the copyright header on the CMake files modified by this PR so the add-license pre-commit hook passes in CI.
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the Windows-specific server build path and keeps the server build flow focused on the supported Unix-style targets.
The change updates
build.pyto reject Windows explicitly as a target platform, removes PowerShell script generation and Windows container build handling, and simplifies the generated build scripts to always use the bash path. It also removes Windows-specific CMake branches from the server build files, including MSVC compile options, Windows protobuf and OpenTelemetry path handling, Windows install renaming fortritonserver.exe, andNOT WIN32guards around tracing, examples, Python frontend packaging, and tests.Rationale
Windows is no longer a supported server build target, so keeping parallel Windows build branches makes the build scripts harder to maintain and creates paths that are no longer expected to work. Failing early in
build.pymakes the unsupported platform behavior explicit, while simplifying CMake keeps the remaining build configuration aligned with the supported Linux/RHEL/iGPU targets.Validation
python3 -m py_compile build.pyto verify the Python build script still parses.git diff --check origin/main...HEADto verify the committed changes do not introduce whitespace errors.build.py,CMakeLists.txt,src/CMakeLists.txt, andsrc/grpc/CMakeLists.txt.