Skip to content

test: Drop no-op perf_analyzer pip install - #8825

Merged
yinggeh merged 1 commit into
mainfrom
yinggeh/fix-perf-analyzer-rhel
Jun 22, 2026
Merged

test: Drop no-op perf_analyzer pip install#8825
yinggeh merged 1 commit into
mainfrom
yinggeh/fix-perf-analyzer-rhel

Conversation

@yinggeh

@yinggeh yinggeh commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Removes the pip3 install perf_analyzer line from several L0 test scripts. The Triton test images already provide perf_analyzer on PATH, so this install resolves to an already-satisfied requirement and never fetches anything — it is a no-op. Dropping it removes a confusing, ineffective step and leaves the tests relying on the image-provided perf_analyzer.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging.
  • All template sections are filled out.

Commit Type:

  • test

Related PRs:

Companion change in the internal RHEL QA image build (same branch name) that puts the SDK-built perf_analyzer on PATH.

Where should the reviewer start?

The removed pip3 install perf_analyzer lines in qa/L0_*/*.sh.

Test plan:

Run the affected L0 perf/test jobs and confirm perf_analyzer still resolves and the tests pass on both standard and RHEL images.

  • CI Pipeline ID: 54260459

Caveats:

None.

Background

pip3 install perf_analyzer finds the package already installed in the image and so never installs the binary itself; the binary is provided by the image build. The line was therefore dead weight.

Related Issues:

N/A

Test plan

@yinggeh
yinggeh requested review from pskiran1 and whoisj June 10, 2026 01:43
@yinggeh yinggeh self-assigned this Jun 10, 2026
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Jun 10, 2026
@yinggeh
yinggeh requested a review from mc-nv June 10, 2026 01:46
@yinggeh
yinggeh merged commit cb67ac7 into main Jun 22, 2026
3 checks passed
@yinggeh
yinggeh deleted the yinggeh/fix-perf-analyzer-rhel branch June 22, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

2 participants