Skip to content

test: fix: L0_server_status - #8827

Merged
whoisj merged 1 commit into
mainfrom
jwyman/tri-1334-buildci-l0_server_status-base
Jun 12, 2026
Merged

test: fix: L0_server_status#8827
whoisj merged 1 commit into
mainfrom
jwyman/tri-1334-buildci-l0_server_status-base

Conversation

@whoisj

@whoisj whoisj commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes the L0_server_status test by using the correct expected value for model_stats count.

Fixes the L0_server_status test by using the correct expected value for model_stats count.
@whoisj whoisj added PR: fix A bug fix PR: test Adding missing tests or correcting existing test labels Jun 10, 2026
self.assertTrue(False, "unexpected error {}".format(ex))


EXPECTED_MODEL_STATS: int = 144

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you figure out what was changed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the number of stats reported.

there's another condition that I was hitting that happens after running ./test.sh multiple times where the model repository gets corrupted. I spent time chasing that problem when it wasn't the real problem.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's because the test isn't idempotent and requires manual clean up of L0_server_status folder before running the test again.

@whoisj
whoisj merged commit 4c36442 into main Jun 12, 2026
3 checks passed
@whoisj
whoisj deleted the jwyman/tri-1334-buildci-l0_server_status-base branch June 12, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix A bug fix PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

3 participants