Skip to content

test: fix: L0_server_status #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whoisj merged 1 commit into from
Jun 12, 2026
Merged

test: fix: L0_server_status #8827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions qa/L0_server_status/server_status_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env python3

# Copyright 2018-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2018-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -428,6 +428,9 @@ def test_model_specific_infer(self):
self.assertTrue(False, "unexpected error {}".format(ex))


EXPECTED_MODEL_STATS: int = 144

@yinggeh yinggeh Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you figure out what was changed?

@whoisj whoisj Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the number of stats reported.

there's another condition that I was hitting that happens after running ./test.sh multiple times where the model repository gets corrupted. I spent time chasing that problem when it wasn't the real problem.

@yinggeh yinggeh Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the number of stats reported.

Was it because I genereated 2 BF16 ONNX models https://github.com/triton-inference-server/server/pull/8782/changes#diff-b0b691449b31f9b36929a5f1dd1edc000ea86264a4078d75318de9cbfb23cbc0?

@whoisj whoisj Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's because the test isn't idempotent and requires manual clean up of L0_server_status folder before running the test again.



class ModelMetadataTest(tu.TestResultCollector):
"""
These tests must be run after the ServerMetadataTest. See test.sh
Expand Down Expand Up @@ -723,8 +726,8 @@ def test_infer_stats_no_model(self):
stats = infer_stats.model_stats
self.assertEqual(
len(stats),
125,
"expected 125 infer stats for all ready versions of all model",
EXPECTED_MODEL_STATS,
f"expected {EXPECTED_MODEL_STATS} infer stats for all ready versions of all model",
)

except InferenceServerException as ex:
Expand Down
10 changes: 5 additions & 5 deletions qa/L0_server_status/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2018-2025, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2018-2026, NVIDIA CORPORATION. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -71,13 +71,13 @@ rm -f $CLIENT_LOG
python $SERVER_STATUS_TEST ServerMetadataTest >>$CLIENT_LOG 2>&1
if [ $? -ne 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Failed\n***"
echo -e "\n***\n*** ServerMetadataTest Failed\n***"
RET=1
else
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS_SMDT
if [ $? -ne 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Result Verification Failed\n***"
echo -e "\n***\n*** ServerMetadataTest Result Verification Failed\n***"
RET=1
fi
fi
Expand All @@ -100,13 +100,13 @@ set +e
python $SERVER_STATUS_TEST ModelMetadataTest >>$CLIENT_LOG 2>&1
if [ $? -ne 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Failed\n***"
echo -e "\n***\n*** ModelMetadataTest Failed\n***"
RET=1
else
check_test_results $TEST_RESULT_FILE $EXPECTED_NUM_TESTS_MMDT
if [ $? -ne 0 ]; then
cat $CLIENT_LOG
echo -e "\n***\n*** Test Result Verification Failed\n***"
echo -e "\n***\n*** ModelMetadataTest Result Verification Failed\n***"
RET=1
fi
fi
Expand Down
Loading