Skip to content

test: Add tests for the Triton log callback#8858

Merged
pskiran1 merged 16 commits into
mainfrom
spolisetty/tri-1194-integrate-triton-logging-into-dynamo
Jul 23, 2026
Merged

test: Add tests for the Triton log callback#8858
pskiran1 merged 16 commits into
mainfrom
spolisetty/tri-1194-integrate-triton-logging-into-dynamo

Conversation

@pskiran1

@pskiran1 pskiran1 commented Jun 25, 2026

Copy link
Copy Markdown
Member

What does the PR do?

Adds QA coverage for the log callback feature. Builds and runs the common logging_test as part of L0_logging, and runs the new test_logging_callback.py in L0_python_api.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 57710794

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

 into spolisetty/tri-1194-integrate-triton-logging-into-dynamo
@pskiran1
pskiran1 requested a review from Vinya567 June 29, 2026 16:58
whoisj
whoisj previously approved these changes Jul 8, 2026
yinggeh
yinggeh previously approved these changes Jul 9, 2026
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR wires up QA coverage for the Triton log-callback feature: the logging_test gtest binary (built by triton-inference-server/common#158) is added to the Docker QA image and executed at the end of L0_logging, and test_logging_callback.py (landed via triton-inference-server/core#504) is exercised through L0_python_api. No logic or server code is changed.

  • Dockerfile.QA: copies bin/logging_test into qa/L0_logging/ inside the cibase stage; requires the binary to be present in CIBASE_IMAGE at build time.
  • qa/L0_logging/test.sh: appends a gtest run of ./logging_test after all existing server-based log tests, using set +e/set -e guards and RET accumulation consistent with the file's existing pattern.
  • qa/L0_python_api/test.sh: adds a fourth pytest block for test_logging_callback.py, matching the structure of the three existing blocks above it.

Confidence Score: 5/5

Safe to merge once the dependent PRs (common#158 and core#504) that produce the binary and the Python test file have landed in the base image.

All three changed files are purely additive test wiring with no server logic or data-path changes. The new code follows the exact same error-accumulation and set+e/set-e patterns used throughout both test scripts.

No files require special attention beyond confirming that the common#158 and core#504 related PRs have merged before running CI.

Important Files Changed

Filename Overview
Dockerfile.QA Adds cp bin/logging_test qa/L0_logging/. to distribute the gtest binary into the QA image; depends on binary being present in CIBASE_IMAGE.
qa/L0_logging/test.sh Appends a gtest-based logging_test run at the tail of the logging test suite; uses >> for log redirection while the existing log_format_test block uses >.
qa/L0_python_api/test.sh Adds a pytest invocation of test_logging_callback.py after the kserve test block; consistent pattern with the three existing pytest invocations in this file.

Reviews (5): Last reviewed commit: "Update" | Re-trigger Greptile

Comment thread qa/L0_python_api/test.sh
Comment thread Dockerfile.QA
@pskiran1
pskiran1 dismissed stale reviews from whoisj and yinggeh via ccbeeb7 July 22, 2026 09:08
Comment thread qa/L0_logging/test.sh Outdated
@pskiran1
pskiran1 requested a review from yinggeh July 23, 2026 10:19
@pskiran1
pskiran1 merged commit 8fd3396 into main Jul 23, 2026
4 checks passed
@pskiran1
pskiran1 deleted the spolisetty/tri-1194-integrate-triton-logging-into-dynamo branch July 23, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: test Adding missing tests or correcting existing test

Development

Successfully merging this pull request may close these issues.

3 participants