Skip to content

ci: Use centralized add-license pre-commit hook#8879

Merged
yinggeh merged 3 commits into
mainfrom
yinggeh/tri-1570-add-pre-commit-copyright-validation-to-remaining-repos
Jul 18, 2026
Merged

ci: Use centralized add-license pre-commit hook#8879
yinggeh merged 3 commits into
mainfrom
yinggeh/tri-1570-add-pre-commit-copyright-validation-to-remaining-repos

Conversation

@yinggeh

@yinggeh yinggeh commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Switches the add-license pre-commit hook from the in-repo tools/add_copyright.py script to the centralized triton-inference-server/pre-commit-hooks repo, and removes the now-unused local script. This standardizes copyright-header validation/insertion across Triton repos.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • ci

Related PRs:

Companion PRs applying the same centralized hook across the other Triton repositories:

Where should the reviewer start?

.pre-commit-config.yaml (now references the shared hook) and the removal of tools/add_copyright.py.

Test plan:

  • Run pre-commit run add-license --all-files locally and confirm it passes with consistent copyright headers.

  • CI Pipeline ID:

Caveats:

The hook now resolves from triton-inference-server/pre-commit-hooks, which must be reachable when running pre-commit locally / in CI.

Background

Consolidates the copyright hook that previously lived in server/tools/add_copyright.py into a single shared pre-commit-hooks repo used by all Triton repos.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@yinggeh yinggeh self-assigned this Jul 11, 2026
@yinggeh
yinggeh requested review from Vinya567, mc-nv and whoisj July 13, 2026 00:26
Vinya567
Vinya567 previously approved these changes Jul 13, 2026
whoisj
whoisj previously approved these changes Jul 15, 2026
mc-nv
mc-nv previously approved these changes Jul 15, 2026
@yinggeh yinggeh added Enhancement New feature or request PR: ci Changes to our CI configuration files and scripts labels Jul 17, 2026
@yinggeh
yinggeh dismissed stale reviews from mc-nv and whoisj via 9ec9ec3 July 17, 2026 23:56
@yinggeh
yinggeh requested review from mc-nv and whoisj July 17, 2026 23:56
@yinggeh
yinggeh merged commit d1e6320 into main Jul 18, 2026
3 checks passed
@yinggeh
yinggeh deleted the yinggeh/tri-1570-add-pre-commit-copyright-validation-to-remaining-repos branch July 18, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request PR: ci Changes to our CI configuration files and scripts

Development

Successfully merging this pull request may close these issues.

4 participants