fix: Enable OpenVINO model generation for SBSA#8883
Merged
Conversation
yinggeh
approved these changes
Jul 14, 2026
whoisj
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Remove the
[[ "aarch64" != $(uname -m) ]]guard around the OpenVINO model generation step inqa/common/gen_qa_model_repository. OpenVINO now supports aarch64 (SBSA) targets, so the QA model repository can generate OpenVINO test models on SBSA runners the same way it does on x86 — closing a gap that caused downstream CI failures (emptyopenvino/*directories →tar: Cowardly refusing to create an empty archivein the per-framework upload loop, e.g.GenModels-build--sbsa-dgx_spark-12.1job 360691523).Checklist
<commit_type>: <Title>Commit Type:
Related PRs:
(none — this change is contained in
server)Where should the reviewer start?
qa/common/gen_qa_model_repository:470-497— the[[ "aarch64" != $(uname -m) ]]conditional wrapping the OpenVINO docker run, its error handling, and the cleanup of$OPENVINOSCRIPTis removed. Every line inside the removed conditional is unindented back to the parent scope; no other logic changes. Diff is+18/-20on a single file.Test plan:
Trigger a full
GenModels-buildmatrix run and confirm OpenVINO models are produced on SBSA runners:GenModels-build--sbsa-a100-8.0,GenModels-build--sbsa-agx_thor-11.0,GenModels-build--sbsa-dgx_spark-12.1,GenModels-build--sbsa-h100-9.0,GenModels-build--sbsa-gb300-10.3,GenModels-build--sbsa-rubin-10.7,GenModels-build--sbsa-gb200-10.0.Inspect SBSA build output (
ls -d */openvino_*) to confirm openvino model directories now exist.Confirm the downstream per-framework upload loop no longer errors on
tar -cvf openvino.tar $(find …)on SBSA — the previous silent-skip / hard-fail path in job 360691523 must be gone.Verify no regression on x86 jobs (
GenModels-build--x86-a100-8.0,GenModels-build--x86-rtx50-12.0,GenModels-build--x86-rubin-10.7) — the OpenVINO generation path is unchanged for x86, just no longer gated.CI Pipeline ID: 57889355
Caveats:
Assumes the base
$UBUNTU_IMAGEused inside the OpenVINO generation step provides an OpenVINO runtime with aarch64 support. If any specific SBSA runner still resolves to an older OpenVINO that lacks ARM support, this will now surface as a real failure inside$OPENVINOSCRIPTrather than the previous silent skip — visible failure is preferable, but worth calling out in case one of the runner images needs a bump.Background
The prior guard was written when OpenVINO had no aarch64 support and the check avoided a hard failure on SBSA runners. OpenVINO gained ARM support (2024+) and the Triton OpenVINO backend now publishes aarch64 artifacts, so the guard is no longer needed. Keeping it caused SBSA CI to attempt to publish an
openvino.tarwith zero contents, which GNUtarrefuses withCowardly refusing to create an empty archive, failingGenModels-build--sbsa-*end-to-end. Full analysis in TRI-1105.Related Issues: