Skip to content

ci: Remove SPDX pre-commit hook#8891

Closed
mc-nv wants to merge 2 commits into
mainfrom
mchornyi/TRI-1100/revert-spdx
Closed

ci: Remove SPDX pre-commit hook#8891
mc-nv wants to merge 2 commits into
mainfrom
mchornyi/TRI-1100/revert-spdx

Conversation

@mc-nv

@mc-nv mc-nv commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Removes the SPDX adoption from the repo:

  • Drops the local add-spdx-license hook from .pre-commit-config.yaml and deletes its script tools/add_spdx_header.py (referenced nowhere else).
  • Replaces the two-line SPDX header with the standard long-form LICENSE (BSD) header on the 6 files that carried it (.pre-commit-config.yaml, build.py, tools/build/build_presets.py, qa/L2_build_presets/{README.md,build_presets_test.py,test.sh}), preserving each file's copyright year range and comment convention.

After this PR the repo contains no SPDX references.

Test plan

  • pre-commit run passes all hooks on every changed file, including add-license (centralized add_copyright.py) over the restored headers.
  • git grep SPDX returns nothing.

Related PRs

mc-nv added 2 commits July 17, 2026 22:20
Drop the local add-spdx-license hook and its tools/add_spdx_header.py
script. Existing two-line SPDX headers remain valid: the centralized
add-license hook maintains the copyright year on the string both header
forms share.
Restore the long-form BSD LICENSE header on the files that were migrated
to (or created with) the two-line SPDX header, preserving each file's
copyright year range.
This was referenced Jul 18, 2026
@mc-nv
mc-nv requested a review from yinggeh July 18, 2026 05:38
@mc-nv
mc-nv marked this pull request as ready for review July 18, 2026 05:38
@mc-nv
mc-nv marked this pull request as draft July 18, 2026 06:42
@mc-nv
mc-nv marked this pull request as ready for review July 20, 2026 23:34
@mc-nv mc-nv closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants