fix(test): regenerate snapshots after upstream sync to v0.24.0#12
Merged
Conversation
The bundled lighthouse output reformatted urlpattern-polyfill's license text and changed McpResponse's tool descriptions. The snapshot test runs only when build/src/third_party/THIRD_PARTY_NOTICES exists (i.e. after npm run bundle, which CI runs but local test:no-build does not), so this failure surfaced only in CI after the v0.4.0 release. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the two snapshot files that drifted after the upstream sync to v0.24.0:
The third_party_notices test only runs when `build/src/third_party/THIRD_PARTY_NOTICES` exists, which happens after `npm run bundle`. CI runs bundle, the local `test:no-build` does not — that's why the failure surfaced only in CI after the 0.4.0 release.
Note: separate pre-existing CI failure
The `Check code before submitting` job is also failing on a different issue — `tests/e2e/brave-integration.test.mjs` triggers an ESLint "Parsing error: not found by the project service". This pre-existed on the previous main, was not introduced by the sync, and is intentionally left out of this PR.
Test plan
🤖 Generated with Claude Code