2222use Symfony \Component \Console \Input \InputInterface ;
2323use Symfony \Component \Console \Output \OutputInterface ;
2424use Symfony \Component \DependencyInjection \ContainerInterface ;
25- use Symfony \Component \Process \Process ;
2625use Trivago \Rumi \Exceptions \SkipException ;
2726use Trivago \Rumi \Models \RunConfig ;
2827use Trivago \Rumi \Services \ConfigReader ;
29- use Trivago \Rumi \Services \ConfigReaderInterface ;
3028
3129class CacheStoreCommand extends CommandAbstract
3230{
@@ -85,16 +83,14 @@ protected function execute(InputInterface $input, OutputInterface $output)
8583 } catch (\Exception $ e ) {
8684 $ output ->writeln ('<error> ' . $ e ->getMessage () . '</error> ' );
8785
88- return $ e ->getCode () != 0 ? $ e ->getCode () : - 1 ;
86+ return $ e ->getCode () !== 0 ? $ e ->getCode () : ReturnCodes:: FAILED ;
8987 }
9088
91- return 0 ;
89+ return ReturnCodes:: SUCCESS ;
9290 }
9391
9492 /**
9593 * @param $cacheDir
96- *
97- * @return Process
9894 */
9995 protected function createCacheDirectory ($ cacheDir )
10096 {
@@ -142,7 +138,7 @@ protected function SkipIfDestCacheDirDoesNotExist(InputInterface $input)
142138 */
143139 protected function SkipIfNotMasterAndCacheFilled ($ argument , $ cacheDir )
144140 {
145- if ($ argument == 'origin/master ' || $ argument == 'master ' ) {
141+ if ($ argument === 'origin/master ' || $ argument = == 'master ' ) {
146142 return ;
147143 }
148144
@@ -156,7 +152,6 @@ protected function SkipIfNotMasterAndCacheFilled($argument, $cacheDir)
156152 private function getCiConfig ()
157153 {
158154 try {
159- /** @var ConfigReaderInterface $configReader */
160155 $ configReader = $ this ->container ->get ('trivago.rumi.services.config_reader ' );
161156
162157 return $ configReader ->getRunConfig ();
0 commit comments