DGMulti shock capturing part 1: cleanup#2940
Conversation
remove extra end remove unnecessary comment
add 3d test
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
DanielDoehring
left a comment
There was a problem hiding this comment.
Thanks Jesse! This is much easier to digest. I have only some very minor comments regarding formatting and naming.
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
==========================================
+ Coverage 97.10% 97.11% +0.01%
==========================================
Files 622 622
Lines 48228 48235 +7
==========================================
+ Hits 46831 46843 +12
+ Misses 1397 1392 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This splits off "cleanup" aspects of #2872 into a smaller PR.
This PR does not implement any new functionality, just cleans up existing functionality for
GaussSBPsolvers and adds a test in 3D (which was supported but not tested).