Skip to content

WIP: Add flux-differencing kernel for nonconservative systems with terms in local*jump form in 3D#2980

Draft
amrueda wants to merge 3 commits into
mainfrom
arr/fluxdiff_kernel_3d_local_jump
Draft

WIP: Add flux-differencing kernel for nonconservative systems with terms in local*jump form in 3D#2980
amrueda wants to merge 3 commits into
mainfrom
arr/fluxdiff_kernel_3d_local_jump

Conversation

@amrueda

@amrueda amrueda commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@amrueda amrueda marked this pull request as draft April 29, 2026 16:49
@github-actions

Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 213 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.71%. Comparing base (5a0811f) to head (0db6258).

Files with missing lines Patch % Lines
src/solvers/dgsem_p4est/dg_3d_subcell_limiters.jl 0.00% 213 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   97.13%   96.71%   -0.43%     
==========================================
  Files         624      624              
  Lines       48439    48652     +213     
==========================================
  Hits        47050    47050              
- Misses       1389     1602     +213     
Flag Coverage Δ
unittests 96.71% <0.00%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bennibolm bennibolm mentioned this pull request Apr 30, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant