Skip to content

Modularize Parabolic Parallel Solver #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DanielDoehring wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Modularize Parabolic Parallel Solver #2989

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f5d2bf
Modularize Parabolic Parallel Solver
DanielDoehring May 3, 2026
30b5912
fmt
DanielDoehring May 3, 2026
f3dd15b
Merge branch 'main' into RefactorMPIP4estParabolic
DanielDoehring May 14, 2026
541b113
Change order
DanielDoehring May 14, 2026
e91fa43
Merge branch 'RefactorMPIP4estParabolic' of github.com:DanielDoehring…
DanielDoehring May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 64 additions & 38 deletions src/solvers/dgsem_p4est/dg_2d_parabolic_parallel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ function rhs_parabolic!(du, u, t,
@unpack parabolic_container = cache_parabolic
@unpack u_transformed, gradients, flux_parabolic = parabolic_container

# Start gradient MPI receive
@trixi_timeit timer() "start MPI receive gradient" begin
start_mpi_receive!(cache.mpi_cache)
end

@trixi_timeit timer() "transform variables" begin
transform_variables!(u_transformed, u, mesh, equations_parabolic,
dg, cache)
end

### Gradient computation ###

# Start gradient MPI receive
@trixi_timeit timer() "start MPI receive gradient" begin
start_mpi_receive!(cache.mpi_cache)
end

# Prolong transformed variables to MPI mortars
@trixi_timeit timer() "prolong2mpimortars gradient" begin
prolong2mpimortars!(cache, u_transformed, mesh, equations_parabolic,
Expand Down Expand Up @@ -67,13 +67,13 @@ function rhs_parabolic!(du, u, t,
dg, parabolic_scheme, cache)
end

# Calculate surface integrals
# Calculate gradient surface integrals
@trixi_timeit timer() "surface integral" begin
calc_surface_integral_gradient!(gradients, mesh, equations_parabolic,
dg, cache)
end

# Apply Jacobian from mapping to reference element
# Apply Jacobian to gradients from mapping to reference element
@trixi_timeit timer() "Jacobian" begin
apply_jacobian_parabolic!(gradients, mesh, equations_parabolic, dg,
cache)
Expand Down Expand Up @@ -123,39 +123,15 @@ function rhs_parabolic!(du, u, t,
start_mpi_send!(cache.mpi_cache, mesh, equations_parabolic, dg, cache)
end

# Local interface fluxes
@trixi_timeit timer() "prolong2interfaces" begin
prolong2interfaces!(cache, flux_parabolic, mesh, equations_parabolic, dg)
end
# Local, i.e., non-MPI interface/boundary/mortar fluxes
calc_interfaces_local!(cache, flux_parabolic, mesh, equations_parabolic,
dg, parabolic_scheme)

@trixi_timeit timer() "interface flux" begin
calc_interface_flux!(cache.elements.surface_flux_values, mesh,
equations_parabolic, dg, parabolic_scheme, cache)
end
calc_boundaries_local!(cache, flux_parabolic, t, mesh, equations_parabolic,
boundary_conditions_parabolic, dg)

# Local boundary fluxes
@trixi_timeit timer() "prolong2boundaries" begin
prolong2boundaries!(cache, flux_parabolic, mesh, equations_parabolic, dg)
end

@trixi_timeit timer() "boundary flux" begin
calc_boundary_flux_divergence!(cache, t,
boundary_conditions_parabolic, mesh,
equations_parabolic,
dg.surface_integral, dg)
end

# Local mortar fluxes
@trixi_timeit timer() "prolong2mortars" begin
prolong2mortars_divergence!(cache, flux_parabolic, mesh, equations_parabolic,
dg.mortar, dg)
end

@trixi_timeit timer() "mortar flux" begin
calc_mortar_flux_divergence!(cache.elements.surface_flux_values,
mesh, equations_parabolic, dg.mortar,
dg, parabolic_scheme, cache)
end
calc_mortars_local!(cache, flux_parabolic, mesh, equations_parabolic,
dg, parabolic_scheme)

# Finish divergence MPI receive
@trixi_timeit timer() "finish MPI receive divergence" begin
Expand All @@ -181,6 +157,7 @@ function rhs_parabolic!(du, u, t,
finish_mpi_send!(cache.mpi_cache)
end

# Re-use `calc_surface_integral!` for the purely hyperbolic case
@trixi_timeit timer() "surface integral" begin
calc_surface_integral!(nothing, du, u, mesh, equations_parabolic,
dg.surface_integral, dg, cache)
Expand All @@ -198,6 +175,55 @@ function rhs_parabolic!(du, u, t,
return nothing
end

function calc_interfaces_local!(cache, flux_parabolic,
mesh::P4estMeshParallel, equations_parabolic,
dg::DG, parabolic_scheme)
@trixi_timeit timer() "prolong2interfaces" begin
prolong2interfaces!(cache, flux_parabolic, mesh, equations_parabolic, dg)
end

@trixi_timeit timer() "interface flux" begin
calc_interface_flux!(cache.elements.surface_flux_values, mesh,
equations_parabolic, dg, parabolic_scheme, cache)
end

return nothing
end

function calc_boundaries_local!(cache, flux_parabolic, t,
mesh::P4estMeshParallel, equations_parabolic,
boundary_conditions_parabolic, dg::DG)
@trixi_timeit timer() "prolong2boundaries" begin
prolong2boundaries!(cache, flux_parabolic, mesh, equations_parabolic, dg)
end

@trixi_timeit timer() "boundary flux" begin
calc_boundary_flux_divergence!(cache, t,
boundary_conditions_parabolic, mesh,
equations_parabolic,
dg.surface_integral, dg)
end

return nothing
end

function calc_mortars_local!(cache, flux_parabolic,
mesh::P4estMeshParallel, equations_parabolic,
dg::DG, parabolic_scheme)
@trixi_timeit timer() "prolong2mortars" begin
prolong2mortars_divergence!(cache, flux_parabolic, mesh, equations_parabolic,
dg.mortar, dg)
end

@trixi_timeit timer() "mortar flux" begin
calc_mortar_flux_divergence!(cache.elements.surface_flux_values,
mesh, equations_parabolic, dg.mortar,
dg, parabolic_scheme, cache)
end

return nothing
end

function calc_gradient_local!(gradients, u_transformed, t,
mesh::P4estMeshParallel{2},
equations_parabolic, boundary_conditions_parabolic,
Expand Down
Loading