varnames cons2thermo#3084
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 647 647
Lines 50022 50024 +2
=======================================
+ Hits 48464 48466 +2
Misses 1558 1558
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jlchan
left a comment
There was a problem hiding this comment.
Thanks for catching this! LGTM
|
Hm, somehow coveralls does not run. That issue popped up yesterday already (that is why I closed & re-opened this PR) |
I noticed in #3079 that
varnamesis not existent forcons2thermowhich prevents saving the solution using this variables.