Skip to content

varnames cons2thermo#3084

Merged
ranocha merged 5 commits into
trixi-framework:mainfrom
DanielDoehring:Varnames_Thermo
Jun 14, 2026
Merged

varnames cons2thermo#3084
ranocha merged 5 commits into
trixi-framework:mainfrom
DanielDoehring:Varnames_Thermo

Conversation

@DanielDoehring

Copy link
Copy Markdown
Member

I noticed in #3079 that varnames is not existent for cons2thermo which prevents saving the solution using this variables.

@DanielDoehring DanielDoehring requested a review from jlchan June 13, 2026 16:48
@DanielDoehring DanielDoehring added enhancement New feature or request visualization labels Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@DanielDoehring DanielDoehring changed the title varnames thermo2cons varnames cons2thermo Jun 13, 2026
@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (d7d4db2) to head (eea5537).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3084   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         647      647           
  Lines       50022    50024    +2     
=======================================
+ Hits        48464    48466    +2     
  Misses       1558     1558           
Flag Coverage Δ
unittests 96.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlchan jlchan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! LGTM

@DanielDoehring DanielDoehring enabled auto-merge (squash) June 13, 2026 17:30
auto-merge was automatically disabled June 13, 2026 19:36

Pull request was closed

@ranocha ranocha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha enabled auto-merge (squash) June 14, 2026 04:07
@DanielDoehring

Copy link
Copy Markdown
Member Author

Hm, somehow coveralls does not run. That issue popped up yesterday already (that is why I closed & re-opened this PR)

@ranocha ranocha disabled auto-merge June 14, 2026 09:06
@ranocha ranocha merged commit 7acbb05 into trixi-framework:main Jun 14, 2026
41 of 75 checks passed
@DanielDoehring DanielDoehring deleted the Varnames_Thermo branch June 14, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request visualization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants