Skip to content

Update Coveralls action in CI workflow#3086

Merged
ranocha merged 1 commit into
mainfrom
hr/update_coveralls
Jun 14, 2026
Merged

Update Coveralls action in CI workflow#3086
ranocha merged 1 commit into
mainfrom
hr/update_coveralls

Conversation

@ranocha

@ranocha ranocha commented Jun 14, 2026

Copy link
Copy Markdown
Member

As mentioned by @DanielDoehring in #3084 (comment), the coveralls GitHub action did not report results in many recent runs (including PRs). The latest CI run on main where it shows up successfully is 42b5759 with coveralls results https://coveralls.io/builds/79945251.

Here, I updated some settings to avoid deprecated functionality. It looks like this helps - at least in this PR.

Closes #3085.

@ranocha ranocha self-assigned this Jun 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@ranocha ranocha removed their assignment Jun 14, 2026
@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.89%. Comparing base (7acbb05) to head (9c7b37d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3086   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         647      647           
  Lines       50024    50024           
=======================================
  Hits        48466    48466           
  Misses       1558     1558           
Flag Coverage Δ
unittests 96.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ranocha ranocha marked this pull request as ready for review June 14, 2026 14:59
@DanielDoehring

Copy link
Copy Markdown
Member

Hm, but something else is now not working 🤔

@ranocha

ranocha commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

Documenter.jl is configured not to run when changes are made only to the CI workflow file, see

- '.github/workflows/ci.yml'

@ranocha

ranocha commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

Thanks for your review! Let's see whether this fixes the issues.

@ranocha ranocha merged commit 1d411ba into main Jun 14, 2026
40 checks passed
@ranocha ranocha deleted the hr/update_coveralls branch June 14, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants