Update Coveralls action in CI workflow#3086
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3086 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 647 647
Lines 50024 50024
=======================================
Hits 48466 48466
Misses 1558 1558
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hm, but something else is now not working 🤔 |
|
Documenter.jl is configured not to run when changes are made only to the CI workflow file, see Trixi.jl/.github/workflows/Documenter.yml Line 11 in 7acbb05 |
|
Thanks for your review! Let's see whether this fixes the issues. |
As mentioned by @DanielDoehring in #3084 (comment), the coveralls GitHub action did not report results in many recent runs (including PRs). The latest CI run on
mainwhere it shows up successfully is 42b5759 with coveralls results https://coveralls.io/builds/79945251.Here, I updated some settings to avoid deprecated functionality. It looks like this helps - at least in this PR.
Closes #3085.