Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 96.88% 97.10% +0.21%
==========================================
Files 28 29 +1
Lines 3369 3621 +252
==========================================
+ Hits 3264 3516 +252
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcoArtiano
changed the title
ranocha
requested changes
Oct 21, 2025
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Thanks! Just a minor round of comments.
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Collaborator
Author
|
@ranocha I've changed the name accordingly and added the comment. This is ready for the final round of review. Thanks! |
PhilBaa
pushed a commit
to PhilBaa/TrixiAtmo.jl
that referenced
this pull request
Jan 26, 2026
* first commit: gravity waves * add first test * add type tests * include tests in runtest.jl * remove some fluxes with orientation * fix tests * fix atol * reach full coverage * fix typo * fix test * Apply suggestions from code review Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com> * add description for Souza non-conservative term * modify comment for Souza flux * fix typo * rename equation and add comment to gravity waves example * fix spell typo error in the comment * small change in a comment --------- Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the 2D compressible Euler Equations with gravity where the prognostic variables are density, momentum and kinetic plus internal energy, instead of the total energy as in #79.
I have few questions about the name, at the moment I decided for
CompressibleEulerInternalKineticEnergyEquationsWithGravity2D, however I'm not sure whether this is the best option, to differentiate it byCompressibleEulerEquationsWithGravity2Dwhere the total energy is the prognostic variable.Other suggestions may be:
CompressibleEulerInternalAndKineticEnergyEquationsWithGravity2DCompressibleEulerKineticInternalEnergyEquationsWithGravity2DCompressibleEulerKineticAndInternalEquationsWithGravity2DDo you have any suggestions @benegee, @tristanmontoya, @amrueda?
Hendrik suggested
CompressibleEulerEnergyEquationsWithGravity2D.To do in new PRs: