Rename compute_smoothed_velocity! → interpolate_fluid_velocity! and fix dispatch

[Copilot]

compute_smoothed_velocity! was incorrectly dispatched only on ViscosityAdami, but the fluid velocity interpolation used for no-slip boundary enforcement should apply to all viscosity models. The same incorrect specialization existed in reset_cache!.

Changes

• Renamed compute_smoothed_velocity! → interpolate_fluid_velocity! to better reflect its role: it accumulates the kernel-weighted fluid velocity sum Σ_b v_b W_ab at each boundary particle location, which is later normalized by volume (= Σ_b W_ab) in compute_wall_velocity! to produce the no-slip wall velocity:

$$\mathbf{v}_w = 2\mathbf{v}_a - \tilde{\mathbf{v}}_a, \quad \tilde{\mathbf{v}}_a = \frac{\sum_b \mathbf{v}_b W_{ab}}{\sum_b W_{ab}}$$

• Fixed dispatch on both interpolate_fluid_velocity! and reset_cache!: the no-op variant now dispatches on viscosity::Nothing; the active variant dispatches generically on any viscosity, instead of only ViscosityAdami.

• Added comments clarifying the relationship between interpolate_fluid_velocity! and compute_wall_velocity! and the no-slip formula being implemented.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/EnzymeAD/Enzyme.jl/tarball/990991b8aa76d17693a98e3a915ac7aa49f08d1a
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/FluxML/MacroTools.jl/tarball/1e0228a030642014fe5cfe68c2c0a818f9e3f522
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaArrays/ArrayInterface.jl/tarball/78b3a7a536b4b0a747a0f296ea77091ca0a9f9a3
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaArrays/FillArrays.jl/tarball/2f979084d1e13948a3352cf64a25df6bd3b4dca3
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaArrays/StaticArrayInterface.jl/tarball/aa1ea41b3d45ac449d10477f65e2b40e3197a0d2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaArrays/StaticArrays.jl/tarball/0f529006004a8be48f1be25f3451186579392d47
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaArrays/StaticArraysCore.jl/tarball/6ab403037779dae8c514bad259f32a447262455a
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaBinaryWrappers/Libiconv_jll.jl/tarball/be484f5c92fad0bd8acfef35fe017900b0b73809
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaBinaryWrappers/OpenSpecFun_jll.jl/tarball/1346c9208249809840c91b26703912dff463d335
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaBinaryWrappers/XML2_jll.jl/tarball/5c959b708667b34cb758e8d7c6f8e69b94c32deb
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaCollections/DataStructures.jl/tarball/e357641bb3e0638d353c4b29ea0e40ea644066a6
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaCollections/OrderedCollections.jl/tarball/05868e21324cede2207c6f0f466b4bfef6d5e7ee
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaCollections/SortingAlgorithms.jl/tarball/64d974c2e6fdf07f8155b5b2ca2ffa9069b608d9
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaConcurrent/Atomix.jl/tarball/29bb0eb6f578a587a49da16564705968667f5fa8
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaConcurrent/UnsafeAtomics.jl/tarball/b13c4edda90890e5b04ba24e20a310fbe6f249ff
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/CSV.jl/tarball/8d8e0b0f350b8e1c91420b5e64e5de774c2f0f4d
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/DataAPI.jl/tarball/abe83f3a2f1b857aac70ef8b269080af17764bbe
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/DataFrames.jl/tarball/d8928e9169ff76c6281f39a659f9bca3a573f24c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/DelimitedFiles.jl/tarball/9e2f36d3c96a820c678f2f1f1782582fcf685bae
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/InvertedIndices.jl/tarball/6da3c4316095de0f5ee2ebd875df8721e7e0bdbe
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/Missings.jl/tarball/ec4f7fbeab05d7747bdf98eb74d130a2a2ed298d
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/Parsers.jl/tarball/7d2f8f21da5db6a806faf7b9b292296da42b2810
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/PooledArrays.jl/tarball/36d8b4b899628fb92c2749eb488d884a926614d3
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/SentinelArrays.jl/tarball/ebe7e59b37c400f694f52b58c93d26201387da70
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/Tables.jl/tarball/f2c1efbc8f3a609aadf318094f8fc5204bdaf344
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaData/WeakRefStrings.jl/tarball/b1be2855ed9ed8eac54e5caff2afcdb442d52c23
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaDiff/DiffResults.jl/tarball/782dd5f4561f5d267313f23853baaaa4c52ea621
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaDiff/DiffRules.jl/tarball/23163d55f885173722d1e4cf0f6110cdbaf7e272
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaDiff/DifferentiationInterface.jl/tarball/7ae99144ea44715402c6c882bfef2adbeadbc4ce
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaDiff/ForwardDiff.jl/tarball/eef4c86803f47dcb61e9b8790ecaa96956fdd8ae
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaDocs/DocStringExtensions.jl/tarball/7442a5dfe1ebb773c29cc2962a8980f47221d76c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaFunctional/CompositionsBase.jl/tarball/802bb88cd69dfd1509f6670416bd4434015693ad
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaGPU/Adapt.jl/tarball/35ea197a51ce46fcd01c4a44befce0578a1aaeca
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaGPU/GPUArrays.jl/tarball/83cf05ab16a73219e5f6bd1bdfa9848fa24ac627
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaGPU/KernelAbstractions.jl/tarball/fb14a863240d62fbf5922bf9f8803d7df6c62dc8
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaIO/CodecZlib.jl/tarball/962834c22b66e32aa10f7611c08c8ca4e20749a9
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaIO/FileIO.jl/tarball/6522cfb3b8fe97bec632252263057996cbd3de20
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaIO/JSON.jl/tarball/b3ad4a0255688dcb895a52fafbaae3023b588a90
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaIO/LightXML.jl/tarball/aa971a09f0f1fe92fe772713a564aa48abe510df
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaIO/TranscodingStreams.jl/tarball/0c45878dcfdcfa8480052b6ab162cdd138781742
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaLang/Compat.jl/tarball/9d8a54ce4b17aa5bdce0ea5c34bc5e7c340d16ad
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaLang/FunctionWrappers.jl/tarball/d62485945ce5ae9c0c48f124a84998d755bae00e
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaLogging/LoggingExtras.jl/tarball/f00544d95982ea270145636c181ceda21c4e2575
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/ChangePrecision.jl/tarball/2ac5097b3caf70b772901abd824e09f991e47296
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/FastPow.jl/tarball/7d961335144dad74de0e1b3a9b60e4d114a78dc2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/InverseFunctions.jl/tarball/a779299d77cd080bf77b97535acecd73e1c5e5cb
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/IrrationalConstants.jl/tarball/b2d91fe939cae05960e760110b328288867b5758
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/NaNMath.jl/tarball/9b8215b1ee9e78a293f99797cd31375471b2bcae
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaMath/SpecialFunctions.jl/tarball/5acc6a41b3082920f79ca3c759acbcecf18a8d78
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaObjects/Accessors.jl/tarball/856ecd7cebb68e5fc87abecd2326ad59f0f911f3
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaObjects/ConstructionBase.jl/tarball/b4b092499347b18a015186eae3042f72267106cb
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaPackaging/JLLWrappers.jl/tarball/0533e564aae234aff59ab625543145446d8b6ec2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/8b770b60760d4451834fe79dd483e318eee709c4
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaPackaging/Requires.jl/tarball/62389eeff14780bfe55195b7204c0d8738436d64
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaPlots/Plots.jl/tarball/5c3d09cc4f31f5fc6af001c250bf1278733100ff
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/BitTwiddlingConvenienceFunctions.jl/tarball/f21cfd4950cb9f0587d5067e69405ad2acd27b87
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/CPUSummary.jl/tarball/f3a21d7fc84ba618a779d1ed2fcca2e682865bab
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/CloseOpenIntervals.jl/tarball/05ba0d07cd4fd8b7a39541e31a7b0254704ea581
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/LayoutPointers.jl/tarball/a9eaadb366f5493a5654e843864c13d8b107548c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/ManualMemory.jl/tarball/bcaef4fc7a0cfe2cba636d84cda54b5e4e4ca3cd
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/Polyester.jl/tarball/16bbc30b5ebea91e9ce1671adc03de2832cff552
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/PolyesterWeave.jl/tarball/645bed98cd47f72f67316fd42fc47dee771aefcd
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/SIMDTypes.jl/tarball/330289636fb8107c5f32088d2741e9fd7a061a5c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/StrideArraysCore.jl/tarball/83151ba8065a73f53ca2ae98bc7274d817aa30f2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaSIMD/ThreadingUtilities.jl/tarball/d969183d3d244b6c33796b5ed01ab97328f2db85
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaServices/StructUtils.jl/tarball/28145feabf717c5d65c1d5e09747ee7b1ff3ed13
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaServices/WorkerUtilities.jl/tarball/cd1659ba0d57b71a464a29e64dbc67cfe83d54e7
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaStats/LogExpFunctions.jl/tarball/13ca9e2586b89836fd20cccf56e57e2b9ae7f38f
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaStats/Statistics.jl/tarball/ae3bb1eb3bba077cd276bc5cfc337cc65c3075c0
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaStrings/InlineStrings.jl/tarball/8f3d257792a522b4601c24a577954b0a8cd7334d
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaStrings/LaTeXStrings.jl/tarball/dda21b8cbd6a6c40d9d02a73230f9d70fed6918c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaTesting/ExprTools.jl/tarball/27415f162e6028e81c72b82ef756bf321213b6ec
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaVTK/ReadVTK.jl/tarball/68e6048d11c3690b69f4779dd38ca22210ac667c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaVTK/VTKBase.jl/tarball/c2d0db3ef09f1942d08ea455a9e252594be5f3b6
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/JuliaVTK/WriteVTK.jl/tarball/a329e0b6310244173690d6a4dfc6d1141f9b9370
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/KristofferC/Crayons.jl/tarball/249fe38abf76d48563e2f4556bebd215aa317e15
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/KristofferC/TimerOutputs.jl/tarball/3748bd928e68c7c346b52125cf41fff0de6937d0
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/Roger-luo/ExproniconLite.jl/tarball/c13f0b150373771b0fdc1713c97860f8df12e6c2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/Roger-luo/Jieko.jl/tarball/2f05ed29618da60c06a87e9c033982d4f71d0b6c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/Roger-luo/Moshi.jl/tarball/53f817d3e84537d84545e0ad749e483412dd6b2a
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/ADTypes.jl/tarball/f7304359109c768cf32dc5fa2d371565bb63b68a
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/CommonSolve.jl/tarball/78ea4ddbcf9c241827e7035c3a03e2e456711470
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/CommonWorldInvalidations.jl/tarball/ae52d1c52048455e85a387fbee9be553ec2b68d0
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/DiffEqBase.jl/tarball/1719cd1b0a12e01775dc6db1577dd6ace1798fee
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/DiffEqCallbacks.jl/tarball/f17b863c2d5d496363fe36c8d8535cc6a33c9952
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/FastPower.jl/tarball/862831f78c7a48681a074ecc9aac09f2de563f71
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/IfElse.jl/tarball/debdd00ffef04665ccbb3e150747a77560e8fad1
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/MaybeInplace.jl/tarball/54e2fdc38130c05b42be423e90da3bade29b74bd
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/MuladdMacro.jl/tarball/cac9cc5499c25554cba55cd3c30543cff5ca4fab
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/NonlinearSolve.jl/tarball/4999dff8efd76814f6662519b985aeda975a1924
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/NonlinearSolve.jl/tarball/4f595a0977d6e048fa1e3c382b088b950f8c7934
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/NonlinearSolve.jl/tarball/e96d5e96debf7f80a50d0b976a13dea556ccfd3a
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/PreallocationTools.jl/tarball/dc8d6bde5005a0eac05ae8faf1eceaaca166cfa4
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/RecursiveArrayTools.jl/tarball/18d2a6fd1ea9a8205cadb3a5704f8e51abdd748b
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/RuntimeGeneratedFunctions.jl/tarball/7257165d5477fd1025f7cb656019dcb6b0512c38
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SciMLBase.jl/tarball/8787e28326c99b0c9c706b51da525ad09d03c56f
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SciMLLogging.jl/tarball/0161be062570af4042cf6f69e3d5d0b0555b6927
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SciMLOperators.jl/tarball/794c760e6aafe9f40dcd7dd30526ea33f0adc8b7
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SciMLPublic.jl/tarball/0ba076dbdce87ba230fff48ca9bca62e1f345c9b
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SciMLStructures.jl/tarball/607f6867d0b0553e98fc7f725c9f9f13b4d01a32
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/Static.jl/tarball/49440414711eddc7227724ae6e570c7d5559a086
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/SymbolicIndexingInterface.jl/tarball/94c58884e013efff548002e8dc2fdd1cb74dfce5
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/SciML/TruncatedStacktraces.jl/tarball/ea3e54c2bdde39062abf5a9758a23735558705e1
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/YingboMa/FastBroadcast.jl/tarball/ab1b34570bcdf272899062e1a56285a53ecaae08
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/c42f/FastClosures.jl/tarball/acebe244d53ee1b461970f8910c235b259e772ef
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/chriselrod/FunctionWrappersWrappers.jl/tarball/b104d487b34566608f8b4e1c39fb0b10aa279ff8
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/fredrikekre/EnumX.jl/tarball/c49898e8438c828577f04b92fc9368c388ac783c
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/jonniedie/ConcreteStructs.jl/tarball/f749037478283d372048690eb3b5f92a79432b34
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/jw3126/Setfield.jl/tarball/c5391c6ace3bc430ca630251d02ea9687169ca68
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/m-j-w/CpuId.jl/tarball/fcbb72b032692610bfbdb15018ac16a36cf2e406
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/queryverse/DataValueInterfaces.jl/tarball/bfc1187b79289637fa0ef6d4436ebdfe6905cbd6
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/queryverse/IteratorInterfaceExtensions.jl/tarball/a3f24677c21f5bbe9d2a714f95dcd58337fb2856
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/queryverse/TableTraits.jl/tarball/c06b2f539df1c6efa794486abfb6ed2022561a39
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/rdeits/CommonSubexpressions.jl/tarball/cda2cfaebb4be89c9084adaca7dd7333369715c5
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/rofinn/FilePathsBase.jl/tarball/3bab2c5aa25e7840a4b065805c0cdfc01f3068d2
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/ronisbr/PrettyTables.jl/tarball/211530a7dc76ab59087f4d4d1fc3f086fbe87594
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/ronisbr/StringManipulation.jl/tarball/d05693d339e37d6ab134c5ab53c29fce5ee5d7d5
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/simonster/Reexport.jl/tarball/45e428421666073eab6f2da5c9d310d99bb12f9b
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/trixi-framework/PointNeighbors.jl/tarball/179d61ce47b27d74e61b1b18bb05cfa08b0a90e4
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• https://api.github.com/repos/trixi-framework/TrixiBase.jl/tarball/e3349c809f5f6677312ffe2e62fc6a49cb3e82f1
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (http block)
• pkg.julialang.org
  • Triggering command: /usr/bin/julia julia --project=. -e import Pkg; Pkg.instantiate() (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>compute_smoothed_velocity! is dispatched incorrectly</issue_title>
<issue_description>

TrixiParticles.jl/src/schemes/boundary/wall_boundary/dummy_particles.jl

Lines 662 to 672 in 9755a09

	@propagate_inbounds function compute_smoothed_velocity!(cache, viscosity::ViscosityAdami,
	neighbor_system, v_neighbor_system,
	kernel_weight, particle, neighbor)
	v_b = current_velocity(v_neighbor_system, neighbor_system, neighbor)
	for dim in eachindex(v_b)
	cache.wall_velocity[dim, particle] += kernel_weight * v_b[dim]
	end
	return cache
	end

Am I missing something, or is this function redundant? It stores something in the wall_velocity, but inside boundary_pressure_extrapolation!. After that, we call compute_adami_density!, which computes the inverse state equation and calls compute_wall_velocity!, which overwrites wall_velocity.

@LasNikas @svchb can you please double-check before I remove this function?</issue_description>

<agent_instructions>it is not correct that compute_smoothed_velocity! is dispatched on ViscosityAdami. This should happen for every viscosity model.
Also, rename compute_smoothed_velocity! to interpolate_fluid_velocity! And add more comments.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@LasNikas IIRC (without looking into the code): `compute_smoothed_velocity` just interpolates the fluid velocity to the boundary particle locations. `compute_wall_velocity!` then calculates the mirrored boundary velocity (therby enforcing the no-slip condition through symmetric viscous coupling). @efaulhaber Yes, but the smoothed velocity calculated in `compute_smoothed_velocity!` is not used in `compute_wall_velocity!`. @efaulhaber > Yes, but the smoothed velocity calculated in compute_smoothed_velocity! is not used in compute_wall_velocity!.

Which is correct btw. $v_a$ in the paper is just the wall velocity, nothing smoothed or interpolated.
</comment_new>
<comment_new>@LasNikas

TrixiParticles.jl/src/schemes/boundary/wall_boundary/dummy_particles.jl

Lines 689 to 692 in 9755a09

	new_velocity = @inbounds 2 * v_boundary[dim] -
	wall_velocity[dim, particle] / volume[particle]
	@inbounds wall_velocity[dim, particle] = new_velocity
	end

It is used in L690?</comment_new>
<comment_new>@svchb
I think its not overwritten if no viscosity is set.

@inline function compute_wall_velocity!(viscosity::Nothing, system, system_coords, particle)
    return viscosity
end
```</body></comment_new>
<comment_new><author>@LasNikas</author><body>
> I think its not overwritten if no viscosity is set.

It is then not calculated at all</body></comment_new>
<comment_new><author>@efaulhaber</author><body>
> It is used in L690?

Ah, you're right. That is correct then.

But it is not correct that `compute_smoothed_velocity!` is dispatched on `ViscosityAdami`. This should happen for every viscosity model.</body></comment_new>
<comment_new><author>@LasNikas</author><body>
> But it is not correct that compute_smoothed_velocity! is dispatched on ViscosityAdami. This should happen for every viscosity model.

Yes, also the naming is very confusing.
</body></comment_new>
<comment_new><author>@efaulhaber</author><body>
> the naming is very confusing.

I think it's good. What would you change? Maybe rename `compute_smoothed_velocity!` to `interpolate_fluid_velocity!`? And add more comments.</body></comment_new>
</comments>

• Fixes compute_smoothed_velocity! is dispatched incorrectly #1071

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.