Make extension only dependent on OrdinaryDiffEqSymplecticRK#1108
Open
vchuravy wants to merge 4 commits intotrixi-framework:mainfrom
Open
Make extension only dependent on OrdinaryDiffEqSymplecticRK#1108vchuravy wants to merge 4 commits intotrixi-framework:mainfrom
vchuravy wants to merge 4 commits intotrixi-framework:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 126 126
Lines 9663 9663
=======================================
Hits 8651 8651
Misses 1012 1012
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vchuravy
commented
Mar 19, 2026
Collaborator
|
This might also be a good place to figure out if we can fix the compat issue of #1047 |
ranocha
reviewed
Mar 24, 2026
|
|
||
| [extensions] | ||
| TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEq", "OrdinaryDiffEqCore"] | ||
| TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"] |
Member
There was a problem hiding this comment.
Would it make sense to rename this to
Suggested change
| TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"] | |
| TrixiParticlesOrdinaryDiffEqSymplecticRKExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"] |
to avoid confusion on which package the extension depends?
Member
There was a problem hiding this comment.
This would have to be renamed to TrixiParticlesOrdinaryDiffEqSymplecticRKExt accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.