Skip to content

Make extension only dependent on OrdinaryDiffEqSymplecticRK#1108

Open
vchuravy wants to merge 4 commits intotrixi-framework:mainfrom
vchuravy:vc/extension
Open

Make extension only dependent on OrdinaryDiffEqSymplecticRK#1108
vchuravy wants to merge 4 commits intotrixi-framework:mainfrom
vchuravy:vc/extension

Conversation

@vchuravy
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.52%. Comparing base (6aeca8c) to head (2905f6f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         126      126           
  Lines        9663     9663           
=======================================
  Hits         8651     8651           
  Misses       1012     1012           
Flag Coverage Δ
total 89.52% <ø> (ø)
unit 67.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Mar 24, 2026

This might also be a good place to figure out if we can fix the compat issue of #1047


[extensions]
TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEq", "OrdinaryDiffEqCore"]
TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to rename this to

Suggested change
TrixiParticlesOrdinaryDiffEqExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"]
TrixiParticlesOrdinaryDiffEqSymplecticRKExt = ["OrdinaryDiffEqSymplecticRK", "OrdinaryDiffEqCore"]

to avoid confusion on which package the extension depends?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would have to be renamed to TrixiParticlesOrdinaryDiffEqSymplecticRKExt accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants