[codex] Fix steady state callback interval handling#1180
Open
svchb wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 89.88% 89.93% +0.04%
==========================================
Files 133 134 +1
Lines 10452 10480 +28
==========================================
+ Hits 9395 9425 +30
+ Misses 1057 1055 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
May 12, 2026
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
requested changes
May 22, 2026
|
|
||
| # Keywords | ||
| - `interval=0`: Check steady state condition every `interval` time steps. | ||
| A value of `0` disables step-interval checks. |
Member
There was a problem hiding this comment.
Suggested change
| A value of `0` disables step-interval checks. | |
| Use either `interval` or `dt`. |
| (note that this may change the solution). | ||
| - `interval_size`: The interval in which the change of the kinetic energy is considered. | ||
| `interval_size` is a (integer) multiple of `interval` or `dt`. | ||
| - Either `interval` or `dt` must be set to something larger than 0. |
Member
There was a problem hiding this comment.
Suggested change
| - Either `interval` or `dt` must be set to something larger than 0. | |
| Use either `interval` or `dt`. |
|
|
||
| function initialize_steady_state_callback!(cb::SteadyStateReachedCallback, u, t, integrator) | ||
| semi = integrator.p.semi | ||
| set_callbacks_used!(semi, integrator) |
| empty!(cb.previous_ekin) | ||
| push!(cb.previous_ekin, convert(eltype(cb.previous_ekin), Inf)) | ||
|
|
||
| return nothing |
Member
There was a problem hiding this comment.
Suggested change
| return nothing | |
| return cb |
Comment on lines
+90
to
+91
| if !steady_state_condition!(cb, integrator) | ||
| u_modified!(integrator, false) |
Member
There was a problem hiding this comment.
Suggested change
| if !steady_state_condition!(cb, integrator) | |
| u_modified!(integrator, false) | |
| u_modified!(integrator, false) | |
| if !steady_state_condition!(cb, integrator) |
Do we even need u_modified! in the condition? Have you checked this?
Comment on lines
+99
to
+100
| u_modified!(integrator, false) | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| u_modified!(integrator, false) |
|
|
||
| u_modified!(integrator, false) | ||
|
|
||
| return nothing |
Member
There was a problem hiding this comment.
Suggested change
| return nothing | |
| return cb |
|
|
||
| u_modified!(integrator, false) | ||
|
|
||
| return nothing |
Member
There was a problem hiding this comment.
Suggested change
| return nothing | |
| return cb |
|
|
||
| # `condition` (`DiscreteCallback`) | ||
| function (steady_state_callback::SteadyStateReachedCallback{Int})(vu_ode, t, integrator) | ||
| condition_steady_state_interval(steady_state_callback, integrator) || return false |
Member
There was a problem hiding this comment.
Suggested change
| condition_steady_state_interval(steady_state_callback, integrator) || return false | |
| if condition_integrator_interval(integrator, cb.interval; save_final_solution=false) | |
| return false | |
| end |
No need for an extra function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intervalbefore evaluating the steady-state kinetic-energy conditioninterval_sizevaluesRoot Cause
The discrete callback condition called
steady_state_condition!directly, sointervalwas never checked. The constructor also chose the previous kinetic-energy vector element type before converting tolerances to a floating type, which made integer tolerances try to storeInfas an integer.Validation
julia --project=. -e 'using Test, TrixiParticles; include("test/callbacks/steady_state_reached.jl")'