Skip to content

Rebuild geometry data after face deletion#1190

Open
svchb wants to merge 5 commits into
trixi-framework:mainfrom
svchb:preprocessing/fix-deleteat-geometry-cache-consistency
Open

Rebuild geometry data after face deletion#1190
svchb wants to merge 5 commits into
trixi-framework:mainfrom
svchb:preprocessing/fix-deleteat-geometry-cache-consistency

Conversation

@svchb

@svchb svchb commented May 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (b3f0e7d) to head (82e6d99).

Files with missing lines Patch % Lines
src/preprocessing/geometries/polygon.jl 96.29% 1 Missing ⚠️
src/preprocessing/geometries/triangle_mesh.jl 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1190      +/-   ##
==========================================
+ Coverage   90.04%   90.11%   +0.07%     
==========================================
  Files         136      136              
  Lines       10595    10620      +25     
==========================================
+ Hits         9540     9570      +30     
+ Misses       1055     1050       -5     
Flag Coverage Δ
total 90.12% <94.11%> (+0.07%) ⬆️
unit 70.88% <94.11%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb self-assigned this May 17, 2026
@svchb svchb added the bug Something isn't working label May 17, 2026
@svchb svchb requested a review from efaulhaber May 27, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants