Skip to content

Fix Julia 1.10 CI fails due to hydrostatic tank validation #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
efaulhaber wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Julia 1.10 CI fails due to hydrostatic tank validation #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/validation/validation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,14 @@
]

# We compare the relative error to the analytical solution
@test isapprox(errors[:edac][2], 0.0, atol=0.033)
@test isapprox(errors[:wcsph][2], 0.0, atol=0.045)
@test isapprox(errors[:edac][2], 0.0, atol=0.031)
if VERSION < v"1.11"
# Julia 1.10 CI tests produce larger errors non-deterministically
# for unknown reasons.
@test isapprox(errors[:wcsph][2], 0.0, atol=0.045)
else
@test isapprox(errors[:wcsph][2], 0.0, atol=0.042)
end
end
@trixi_testset "TGV_2D" begin
@trixi_test_nowarn trixi_include(@__MODULE__,
Expand Down
Loading