Skip to content

Validation Carreau Yasuda Model #1207

Open
sherin-joseph wants to merge 2 commits into
trixi-framework:mainfrom
sherin-joseph:validation-carreau-yasuda
Open

Validation Carreau Yasuda Model #1207
sherin-joseph wants to merge 2 commits into
trixi-framework:mainfrom
sherin-joseph:validation-carreau-yasuda

Conversation

@sherin-joseph
Copy link
Copy Markdown
Contributor

Please note that this is more of a steady-profile preservation check than a full convergence-from-rest validation, because the default and high-resolution runs use analytical initial conditions. . For a stronger transient validation, we need to use initial_condition_mode = zero or newtonian and verify convergence of the velocity profile toward the analytical solution.

The relative L2 velocity-profile error remains below 3% for all tested Carreau-Yasuda indices at ny = 200. The largest error occurs for n = 0.25, the strongest shear-thinning case, while the Newtonian limit n = 1 is recovered with about 1.4% relative L2 error.

carreau_error_comparison carreau_final_profiles

The reference Poiseuille validation from Section 3.1 of Coclite et al. (2020) is shown below for comparison.

image

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented May 21, 2026

For validation cases we want to have the following structure:

  1. example file that is trixi_include'd into the validation_run file
  2. the validation run file contain some kind of error bounds
  3. Additionally a plot file to plot the results of the validation run.

So you just need to create this additional example file and figure out an error bound for the validation to get to that structure.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (8780b50) to head (69c61f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1207   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         135      135           
  Lines       10569    10569           
=======================================
  Hits         9513     9513           
  Misses       1056     1056           
Flag Coverage Δ
total 90.01% <ø> (ø)
unit 70.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sherin-joseph sherin-joseph force-pushed the validation-carreau-yasuda branch from 028501c to 0ec9cb8 Compare May 21, 2026 11:09
@sherin-joseph
Copy link
Copy Markdown
Contributor Author

@svchb
The PR now includes:

examples/fluid/poiseuille_carreau_2d.jl as the example file
validation/poiseuille_carreau_2d/validation_poiseuille_carreau_2d.jl as the validation runner using trixi_include
relative L2 error bounds in the validation runner
plot_carreau_comparison.jl for plotting the validation results

I hope this follows the expected structure now. Please let me know if any further changes or corrections are needed.

Thanks for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants