Skip to content

Softening model#1209

Draft
svchb wants to merge 9 commits into
trixi-framework:mainfrom
svchb:softening_model
Draft

Softening model#1209
svchb wants to merge 9 commits into
trixi-framework:mainfrom
svchb:softening_model

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented May 22, 2026

Based on #1208.

Summary

Replaces the scalar softening_length API from #1208 with explicit gravitational softening models. The public softening models are NoSoftening and PlummerSoftening; the abstract softening/model hooks remain internal.

Updates the n-body example system to carry the softening model through its gravity conversion path and to compute potential energy through the gravity softening helper. The docs page and base n-body allocation/energy tests now live in #1208, so this PR is focused on the softening-model API delta.

Testing

  • test/general/gravity.jl
  • test/examples/n_body_system.jl

@svchb svchb marked this pull request as draft May 22, 2026 19:42
@svchb svchb self-assigned this May 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.04%. Comparing base (71d42df) to head (15e2e8d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/general/gravity.jl 95.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
+ Coverage   89.88%   90.04%   +0.16%     
==========================================
  Files         133      138       +5     
  Lines       10452    10642     +190     
==========================================
+ Hits         9395     9583     +188     
- Misses       1057     1059       +2     
Flag Coverage Δ
total 90.05% <95.89%> (+0.17%) ⬆️
unit 70.74% <75.34%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb force-pushed the softening_model branch from 353ca10 to 15e2e8d Compare May 22, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant