Softening model#1209
Draft
svchb wants to merge 9 commits into
Draft
Conversation
…s.jlOpen into self_gravity # Conflicts: # examples/n_body/n_body_system.jl
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
+ Coverage 89.88% 90.04% +0.16%
==========================================
Files 133 138 +5
Lines 10452 10642 +190
==========================================
+ Hits 9395 9583 +188
- Misses 1057 1059 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #1208.
Summary
Replaces the scalar
softening_lengthAPI from #1208 with explicit gravitational softening models. The public softening models areNoSofteningandPlummerSoftening; the abstract softening/model hooks remain internal.Updates the n-body example system to carry the softening model through its gravity conversion path and to compute potential energy through the gravity softening helper. The docs page and base n-body allocation/energy tests now live in #1208, so this PR is focused on the softening-model API delta.
Testing
test/general/gravity.jltest/examples/n_body_system.jl