Skip to content

Test Julia 1.12#717

Merged
efaulhaber merged 35 commits intomainfrom
test-1.12
Mar 25, 2026
Merged

Test Julia 1.12#717
efaulhaber merged 35 commits intomainfrom
test-1.12

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Feb 14, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.52%. Comparing base (55951e4) to head (4e572c4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #717   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files         126      126           
  Lines        9663     9663           
=======================================
  Hits         8651     8651           
  Misses       1012     1012
Flag Coverage Δ
total 89.52% <ø> (ø)
unit 67.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb marked this pull request as draft March 26, 2025 17:13
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Apr 4, 2025

Beta1: several upstream packages are broken

@svchb svchb closed this Apr 30, 2025
@svchb svchb reopened this Apr 30, 2025
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Apr 30, 2025

Errors with beta2:

general: Test Failed at /home/runner/work/TrixiParticles.jl/TrixiParticles.jl/test/test_util.jl:80
Expression: occursin(r"^(WARNING: replacing module .+.\n)$", stderr_content)
Evaluated: occursin(r"^(WARNING: replacing module .+.\n)$", "WARNING: llvmcall with integer pointers is deprecated.\nUse actual pointers instead, replacing i32 or i64 with i8* or ptr\nin _vsum(Any, Base.Colon, Static.False) at /home/runner/.julia/packages/VectorizedStatistics/lBP0N/src/vsum.jl\n")

@svchb svchb closed this May 13, 2025
@svchb svchb reopened this May 13, 2025
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Jun 16, 2025

beta4:
dam_break_2d: Test Failed at /home/runner/work/TrixiParticles.jl/TrixiParticles.jl/test/validation/validation.jl:70
Expression: isapprox(error_wcsph_P1, 0, atol = eps())
Evaluated: isapprox(220.8179623950896, 0; atol = 2.220446049250313e-16)

and 19 cases fail because of this warning:
WARNING: llvmcall with integer pointers is deprecated.\nUse actual pointers instead, replacing i32 or i64 with i8* or ptr\nin unique_sorted(Any)

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Jul 16, 2025

RC1:
WARNING: llvmcall with integer pointers is deprecated.
634
Use actual pointers instead, replacing i32 or i64 with i8* or ptr
635
in var"#update_grid!#71"(Any, Any, typeof(PointNeighbors.update_grid!), Union{PointNeighbors.GridNeighborhoodSearch{var"#s6", PointNeighbors.SemiParallelUpdate, CL, ELTYPE, PB, UB} where UB where PB where ELTYPE where CL where var"#s6", PointNeighbors.GridNeighborhoodSearch{var"#s7", PointNeighbors.SerialIncrementalUpdate, CL, ELTYPE, PB, UB} where UB where PB where ELTYPE where CL where var"#s7"}, AbstractArray{T, 2} where T) at /home/runner/.julia/packages/PointNeighbors/jcoWH/src/nhs_grid.jl

WARNING: llvmcall with integer pointers is deprecated.
Use actual pointers instead, replacing i32 or i64 with i8* or ptr
in (::PointNeighbors.var"#parallel_foreach##4#parallel_foreach##5"{f, var"#40#range"})(Any, PointNeighbors.var"#parallel_foreach##2#parallel_foreach##3"{var"#41#threadsfor_fun#4"} where var"#41#threadsfor_fun#4", Any) at threadingconstructs.jl

Test Summary: | Pass Fail Total Time
All Tests | 298 10 308 64m30.6s
Examples | 276 6 282 49m07.7s
Fluid | 238 6 244 42m23.0s
fluid/hydrostatic_water_column_2d.jl | 59 4 63 4m19.9s
EDAC with ViscosityAdami | 2 1 3 25.7s
WCSPH with WendlandC6Kernel | 3 3 13.0s
WCSPH with WendlandC2Kernel | 3 3 12.5s
WCSPH with WendlandC4Kernel | 3 3 12.5s
WCSPH with ViscosityAdami and SummationDensity | 3 3 12.2s
with Threads.@threads :dynamic | 2 1 3 12.0s
WCSPH with SchoenbergQuinticSplineKernel | 3 3 12.1s
WCSPH with SchoenbergQuarticSplineKernel | 3 3 17.1s
WCSPH with ViscosityMorris | 3 3 9.9s
WCSPH with smoothing_length=1.3 | 3 3 9.5s
with SerialBackend | 3 3 8.5s
WCSPH with FullGridCellList | 2 1 3 12.3s
WCSPH with ViscosityAdami | 3 3 10.0s
EDAC with source term damping | 3 3 9.5s
WCSPH with SummationDensity | 3 3 11.4s
WCSPH default | 3 3 4.2s
EDAC with SummationDensity | 3 3 10.7s
WCSPH with ViscosityMorris and SummationDensity | 3 3 10.8s
EDAC with ViscosityMorris | 3 3 10.3s
WCSPH with source term damping | 3 3 10.3s
with Threads.@threads :static | 2 1 3 10.4s
fluid/oscillating_drop_2d.jl | 4 4 36.4s
fluid/hydrostatic_water_column_3d.jl | 3 3 21.4s
fluid/hydrostatic_water_column_3d.jl with SummationDensity | 3 3 23.2s
fluid/accelerated_tank_2d.jl | 3 3 10.1s
fluid/dam_break_2d.jl | 24 1 25 6m53.0s
with KernelAbstractions | 2 1 3 36.9s
with SurfaceTensionAkinci | 3 3 3m21.0s
with DensityDiffusionMolteniColagrossi | 3 3 18.0s
default | 3 3 30.4s
with SummationDensity | 3 3 33.0s
with BoundaryModelMonaghanKajtar | 3 3 28.2s
no density diffusion | 3 3 15.3s
Float32 | 4 4 49.6s
fluid/dam_break_2d_gpu.jl | 4 4 33.4s
fluid/dam_break_oil_film_2d.jl | 3 3 45.9s
fluid/dam_break_2phase_2d.jl | 3 3 1m20.1s
fluid/dam_break_3d.jl | 3 3 15.1s
fluid/falling_water_column_2d.jl | 3 3 10.2s
fluid/periodic_channel_2d.jl | 3 3 14.9s
fluid/periodic_channel_2d.jl with PST | 3 3 8.3s
fluid/periodic_channel_2d.jl with PST and TIC | 3 3 12.2s
fluid/pipe_flow_2d.jl - BoundaryModelLastiwka (WCSPH) | 2 1 3 1m05.4s
fluid/pipe_flow_2d.jl - BoundaryModelLastiwka (EDAC) | 3 3 57.5s
fluid/pipe_flow_2d.jl - BoundaryModelTafuni (EDAC) | 3 3 42.2s
fluid/pipe_flow_2d.jl - BoundaryModelTafuni (WCSPH) | 3 3 43.9s
fluid/pipe_flow_2d.jl - steady state reached (dt) | 3 3 45.6s
fluid/pipe_flow_2d.jl - steady state reached (interval) | 3 3 41.5s
fluid/pipe_flow_3d.jl | 3 3 1m29.3s
fluid/lid_driven_cavity_2d.jl (EDAC) | 3 3 26.3s
fluid/lid_driven_cavity_2d.jl (WCSPH) | 3 3 23.1s
fluid/taylor_green_vortex_2d.jl (EDAC) | 3 3 15.7s
fluid/taylor_green_vortex_2d.jl (WCSPH) | 3 3 9.5s
fluid/sphere_surface_tension_2d.jl | 3 3 17.5s
fluid/periodic_array_of_cylinders_2d.jl | 3 3 24.3s
fluid/sphere_surface_tension_3d.jl | 3 3 46.3s
fluid/falling_water_spheres_2d.jl | 12 12 2m39.8s
SurfaceTensionAkinci | 3 3 46.6s
SurfaceTensionNone | 3 3 29.8s
SurfaceTensionMomentumMorris | 3 3 40.1s
SurfaceTensionMorris | 3 3 42.6s
fluid/falling_water_spheres_3d.jl | 12 12 6m22.1s
SurfaceTensionAkinci | 3 3 1m50.2s
SurfaceTensionNone | 3 3 32.3s
SurfaceTensionMomentumMorris | 3 3 1m60.0s
SurfaceTensionMorris | 3 3 1m59.7s
fluid/sphere_surface_tension_wall_2d.jl | 1 1 3m06.2s
fluid/moving_wall_2d.jl | 3 3 10.3s
dam_break_2d.jl with corrections | 36 36 3m34.8s
continuity_reinit | 3 3 11.3s
gradient_continuity_correction | 3 3 19.9s
gradient_summation_correction | 3 3 19.7s
no_correction | 3 3 12.2s
shepard_kernel_correction | 3 3 14.7s
blended_gradient_continuity_correction | 3 3 19.4s
mixed_kernel_gradient_summation_correction | 3 3 26.5s
akinci_free_surf_correction | 3 3 11.7s
kernel_correction_summation_correction | 3 3 17.2s
mixed_kernel_gradient_continuity_correction | 3 3 25.0s
kernel_correction_continuity_correction | 3 3 16.5s
blended_gradient_summation_correction | 3 3 19.9s
SymplecticPositionVerlet | 12 12 55.9s
Solid | 3 3 14.7s
solid/oscillating_beam_2d.jl | 3 3 14.7s
FSI | 12 12 3m10.8s
fsi/falling_water_column_2d.jl | 3 3 21.5s
fsi/dam_break_plate_2d.jl | 3 3 34.5s
fsi/dam_break_gate_2d.jl | 3 3 43.2s
fsi/falling_spheres_2d.jl | 3 3 1m31.5s
N-Body | 6 6 31.5s
n_body/n_body_solar_system.jl | 3 3 5.0s
n_body/n_body_benchmark_trixi.jl | 1 1 18.5s
n_body/n_body_benchmark_reference.jl | 1 1 4.0s
n_body/n_body_benchmark_reference_faster.jl | 1 1 3.8s
Postprocessing | 6 6 55.0s
postprocessing/interpolation_plane.jl | 2 2 38.3s
postprocessing/interpolation_point_line.jl | 2 2 2.5s
postprocessing/postprocessing.jl | 2 2 14.0s
Preprocessing | 5 5 1m35.3s
preprocessing/packing_2d.jl | 2 2 16.1s
preprocessing/packing_2d.jl validation | 2 2 0.7s
preprocessing/packing_3d.jl | 1 1 1m18.4s
DEM | 3 3 8.7s
dem/rectangular_tank_2d.jl | 3 3 8.7s
dem/collapsing_sand_pile_3d.jl | 3 3 8.4s
Validation | 22 4 26 15m22.8s
general | 4 4 41.3s
oscillating_beam_2d | 7 7 1m32.1s
dam_break_2d | 5 4 9 10m26.3s
TGV_2D | 3 3 29.7s
LDC_2D | 3 3 2m13.2s

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Sep 29, 2025

RC2:
Test Summary: | Pass Fail Total Time
All Tests | 301 10 311 66m19.9s
Examples | 279 6 285 50m26.9s
Fluid | 238 6 244 43m21.3s
fluid/hydrostatic_water_column_2d.jl | 59 4 63 4m29.2s
EDAC with ViscosityAdami | 2 1 3 26.7s
WCSPH with WendlandC6Kernel | 3 3 13.9s
WCSPH with WendlandC2Kernel | 3 3 12.5s
WCSPH with WendlandC4Kernel | 3 3 12.9s
WCSPH with ViscosityAdami and SummationDensity | 3 3 12.5s
with Threads.@threads :dynamic | 2 1 3 12.5s
WCSPH with SchoenbergQuinticSplineKernel | 3 3 13.0s
WCSPH with SchoenbergQuarticSplineKernel | 3 3 17.1s
WCSPH with ViscosityMorris | 3 3 10.3s
WCSPH with smoothing_length=1.3 | 3 3 10.4s
with SerialBackend | 3 3 8.8s
WCSPH with FullGridCellList | 2 1 3 12.7s
WCSPH with ViscosityAdami | 3 3 10.5s
EDAC with source term damping | 3 3 10.1s
WCSPH with SummationDensity | 3 3 12.1s
WCSPH default | 3 3 4.6s
EDAC with SummationDensity | 3 3 11.4s
WCSPH with ViscosityMorris and SummationDensity | 3 3 11.5s
EDAC with ViscosityMorris | 3 3 10.9s
WCSPH with source term damping | 3 3 11.0s
with Threads.@threads :static | 2 1 3 11.2s
fluid/oscillating_drop_2d.jl | 4 4 37.3s
fluid/hydrostatic_water_column_3d.jl | 3 3 22.2s
fluid/hydrostatic_water_column_3d.jl with SummationDensity | 3 3 24.0s
fluid/accelerated_tank_2d.jl | 3 3 10.8s
fluid/dam_break_2d.jl | 24 1 25 7m08.8s
with KernelAbstractions | 2 1 3 37.1s
with SurfaceTensionAkinci | 3 3 3m30.8s
with DensityDiffusionMolteniColagrossi | 3 3 18.3s
default | 3 3 31.7s
with SummationDensity | 3 3 33.9s
with BoundaryModelMonaghanKajtar | 3 3 29.5s
no density diffusion | 3 3 15.3s
Float32 | 4 4 51.5s
fluid/dam_break_2d_gpu.jl | 4 4 34.3s
fluid/dam_break_oil_film_2d.jl | 3 3 43.2s
fluid/dam_break_2phase_2d.jl | 3 3 1m02.1s
fluid/dam_break_3d.jl | 3 3 16.3s
fluid/falling_water_column_2d.jl | 3 3 10.5s
fluid/periodic_channel_2d.jl | 3 3 15.0s
fluid/periodic_channel_2d.jl with PST | 3 3 8.6s
fluid/periodic_channel_2d.jl with PST and TIC | 3 3 12.6s
fluid/pipe_flow_2d.jl - BoundaryModelLastiwka (WCSPH) | 2 1 3 1m03.2s
fluid/pipe_flow_2d.jl - BoundaryModelLastiwka (EDAC) | 3 3 55.5s
fluid/pipe_flow_2d.jl - BoundaryModelTafuni (EDAC) | 3 3 44.9s
fluid/pipe_flow_2d.jl - BoundaryModelTafuni (WCSPH) | 3 3 46.3s
fluid/pipe_flow_2d.jl - steady state reached (dt) | 3 3 42.8s
fluid/pipe_flow_2d.jl - steady state reached (interval) | 3 3 39.9s
fluid/pipe_flow_3d.jl | 3 3 1m28.8s
fluid/lid_driven_cavity_2d.jl (EDAC) | 3 3 30.7s
fluid/lid_driven_cavity_2d.jl (WCSPH) | 3 3 25.2s
fluid/taylor_green_vortex_2d.jl (EDAC) | 3 3 16.6s
fluid/taylor_green_vortex_2d.jl (WCSPH) | 3 3 9.7s
fluid/sphere_surface_tension_2d.jl | 3 3 18.4s
fluid/periodic_array_of_cylinders_2d.jl | 3 3 31.5s
fluid/sphere_surface_tension_3d.jl | 3 3 47.2s
fluid/falling_water_spheres_2d.jl | 12 12 2m43.9s
SurfaceTensionAkinci | 3 3 47.3s
SurfaceTensionNone | 3 3 31.3s
SurfaceTensionMomentumMorris | 3 3 41.4s
SurfaceTensionMorris | 3 3 43.3s
fluid/falling_water_spheres_3d.jl | 12 12 6m34.6s
SurfaceTensionAkinci | 3 3 1m53.1s
SurfaceTensionNone | 3 3 37.6s
SurfaceTensionMomentumMorris | 3 3 2m02.9s
SurfaceTensionMorris | 3 3 2m01.0s
fluid/sphere_surface_tension_wall_2d.jl | 1 1 3m07.3s
fluid/moving_wall_2d.jl | 3 3 11.1s
dam_break_2d.jl with corrections | 36 36 3m50.1s
continuity_reinit | 3 3 12.2s
gradient_continuity_correction | 3 3 20.8s
gradient_summation_correction | 3 3 20.9s
no_correction | 3 3 13.0s
shepard_kernel_correction | 3 3 15.8s
blended_gradient_continuity_correction | 3 3 20.7s
mixed_kernel_gradient_summation_correction | 3 3 29.1s
akinci_free_surf_correction | 3 3 13.1s
kernel_correction_summation_correction | 3 3 19.7s
mixed_kernel_gradient_continuity_correction | 3 3 25.7s
kernel_correction_continuity_correction | 3 3 17.4s
blended_gradient_summation_correction | 3 3 20.7s
SymplecticPositionVerlet | 12 12 57.4s
Solid | 6 6 31.0s
solid/oscillating_beam_2d.jl | 3 3 16.1s
solid/oscillating_beam_2d.jl with penalty force and viscosity | 3 3 14.8s
FSI | 12 12 3m14.7s
fsi/falling_water_column_2d.jl | 3 3 21.9s
fsi/dam_break_plate_2d.jl | 3 3 34.8s
fsi/dam_break_gate_2d.jl | 3 3 44.6s
fsi/falling_spheres_2d.jl | 3 3 1m33.3s
N-Body | 6 6 33.5s
n_body/n_body_solar_system.jl | 3 3 5.1s
n_body/n_body_benchmark_trixi.jl | 1 1 20.3s
n_body/n_body_benchmark_reference.jl | 1 1 4.0s
n_body/n_body_benchmark_reference_faster.jl | 1 1 3.9s
Postprocessing | 6 6 52.8s
postprocessing/interpolation_plane.jl | 2 2 36.4s
postprocessing/interpolation_point_line.jl | 2 2 2.5s
postprocessing/postprocessing.jl | 2 2 13.8s
Preprocessing | 5 5 1m36.1s
preprocessing/packing_2d.jl | 2 2 16.1s
preprocessing/packing_2d.jl validation | 2 2 0.7s
preprocessing/packing_3d.jl | 1 1 1m19.3s
DEM | 3 3 8.6s
dem/rectangular_tank_2d.jl | 3 3 8.6s
dem/collapsing_sand_pile_3d.jl | 3 3 8.6s
Validation | 22 4 26 15m52.9s
general | 4 4 38.7s
oscillating_beam_2d | 7 7 1m33.5s
dam_break_2d | 5 4 9 10m35.2s
TGV_2D | 3 3 31.2s
LDC_2D | 3 3 2m33.4s

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Oct 8, 2025

/run-tests-gpu

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Oct 8, 2025

/run-gpu-tests

efaulhaber
efaulhaber reviewed Jan 15, 2026
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Jan 16, 2026

I traced the warnings back to the Atomix.@atomic lines in PN. No idea why we are getting them, so I created an issue:
JuliaConcurrent/Atomix.jl#65

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 21, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 21, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 21, 2026 •
edited
Loading

GPU tests are still broken #1115 on 1.12

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 21, 2026

/run-gpu-tests

efaulhaber
efaulhaber requested changes Mar 23, 2026
View reviewed changes
Comment thread validation/hydrostatic_water_column_2d/validation.jl Outdated
svchb and others added 2 commits March 23, 2026 13:13
@svchb @efaulhaber
Update validation/hydrostatic_water_column_2d/validation.jl
79a83fd 
Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
@svchb
Merge branch 'main' into test-1.12
30b66f3
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 23, 2026

/run-gpu-tests

@svchb svchb requested a review from efaulhaber March 24, 2026 09:05
@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

1 similar comment
@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

1 similar comment
@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

@efaulhaber
Copy link
Copy Markdown
Member

efaulhaber commented Mar 25, 2026

/run-gpu-tests

@efaulhaber efaulhaber merged commit 6aeca8c into main Mar 25, 2026
20 checks passed
@efaulhaber efaulhaber deleted the test-1.12 branch March 25, 2026 21:36
@efaulhaber efaulhaber mentioned this pull request Mar 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efaulhaber efaulhaber efaulhaber approved these changes

Assignees

@svchb svchb

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@svchb @efaulhaber