Merge dev to main#832
Merged
efaulhaber merged 20 commits intomainfrom Sep 19, 2025
Merged
Conversation
svchb
added
the
breaking changes
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 70.96% 68.96% -2.00%
==========================================
Files 108 109 +1
Lines 7047 7415 +368
==========================================
+ Hits 5001 5114 +113
- Misses 2046 2301 +255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LasNikas
force-pushed
the
dev
branch
2 times, most recently
from
08de264 to
ce0ed1d
Compare
LasNikas
force-pushed
the
dev
branch
4 times, most recently
from
b65cd6e to
6de7ad3
Compare
* rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
* Combine PST and TVF into a unified framework * Require update callback for PST * Fix WCSPH * Update PST only in callback * Fix EDAC * Update docs * Fix alle example files * Fix tests * Fix periodic channel * Fix docs * Update news * Fix tests * Fix example file
* add dvu_ode vector to custom quantities * add for fluid and boundary * fix tests * fix tests * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Combine PST and TVF into a unified framework (#884) * Combine PST and TVF into a unified framework * Require update callback for PST * Fix WCSPH * Update PST only in callback * Fix EDAC * Update docs * Fix alle example files * Fix tests * Fix periodic channel * Fix docs * Update news * Fix tests * Fix example file * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Combine PST and TVF into a unified framework (#884) * Combine PST and TVF into a unified framework * Require update callback for PST * Fix WCSPH * Update PST only in callback * Fix EDAC * Update docs * Fix alle example files * Fix tests * Fix periodic channel * Fix docs * Update news * Fix tests * Fix example file * fix tests * fix doctests * implement suggestions * fix tests * fix tests * implement suggestions * fix * fix --------- Co-authored-by: LasNikas <niklas.nehe@web.de> Co-authored-by: Sven Berger <berger.sven@gmail.com> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
* swap extrapolation * swap density pressure * adapt docs * rm example * fix missing nhs update * implement different mirror methods * add docs * fix tests * fix typos * add docs * add tests * apply formatter * add `average_velocity!` for `BoundaryModelLastiwka` * fix * add interpolation functions * restructure again * fix gpu bugs * remove unnecessary argument * fix gpu again * fix gpu * implement suggestions * fix * add comments * implement suggestions * first prototype: NOT VALIDATED YET * fix avg vel in LastiwkaModel * fix avg in mirroring * fix tests * adapt example file * fix allocations * fix gpu * first GPU working prototype * improve API * fix tests * rm export * fix * fix type stability * implement suggestions * rm ref * format * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * fix merge bugs * supersede #852 * supersede #850 * fix * rename boundary models * fix? * fix tests * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * fix characteristics * revise pipe flow example * fix include bug * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Combine PST and TVF into a unified framework (#884) * Combine PST and TVF into a unified framework * Require update callback for PST * Fix WCSPH * Update PST only in callback * Fix EDAC * Update docs * Fix alle example files * Fix tests * Fix periodic channel * Fix docs * Update news * Fix tests * Fix example file * add doc strings * implement suggestions * remove duplicated system * rm unnecessary variable * apply formatter * set pressure for WCSPH * setter for open boundary * rename reference values * fix gpu tests * fix sign * implement suggestions * fix unit tests * revise doc strings * add NEWS entry * update NEWS --------- Co-authored-by: LasNikas <niklas.nehe@web.de> Co-authored-by: Sven Berger <berger.sven@gmail.com> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
* Implement consistent shifting by Sun et al. 2019 * Fix tests * Add option to switch between dynamic and static v_max * Fix docs * Add more constructor tests * Fix `dv_shifting` * Add reference * Remove doctest output * Fix ugly spaces * Fix tests * Fix tests * Update NEWS.md * Reformat * Add #879 to NEWS.md * Fix tests * Revise docstring * Make API more flexible * Fix tests
* Integrate write2json for initial metadata export * Remove old `write_meta_data` parameter from VTK writing functions and callbacks * Add `solver_name` to metadata and format files * update `write2json.jl` to match merge * rename file * update references * rename function * Refactor write2vtk! * formatting * refactor functions * implement suggestions * fix bugs * add add_meta_data! function for `system::ParticlePackingSystem` * relocate `add_meta_data!` to `system.jl` * formatting * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * dispatch `FluidSystem` * Write one unified metadata file for all systems * improve JSON-file structure * improve consistency * Enhance structure of the JSON-File * Fix `rho0` in `AkinciFreeSurfaceCorrection` * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Refactor metadata handling * Add settable filename * Add filename display to SolutionSavingCallback output * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * add function for `ParticlePackingSystem` * improve structure * Formatting Code * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * fix failing tests * Rename 'tlsph' to 'place_on_shell' (#814) * rename * format * forgot some * format * naming * forgot some more * fix test * incorporate review comments * format --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> * Combine PST and TVF into a unified framework (#884) * Combine PST and TVF into a unified framework * Require update callback for PST * Fix WCSPH * Update PST only in callback * Fix EDAC * Update docs * Fix alle example files * Fix tests * Fix periodic channel * Fix docs * Update news * Fix tests * Fix example file * improve structure and fixing problems * add `shifting_technique` to `io.jl` * change filename of the JSON-File * add suggestions * Enhance data handling for `OpenBoundarySPHSystem` * correct formatting issue * Remove autoinfiltrate * rename `number_of_threads` --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> Co-authored-by: Sven Berger <berger.sven@gmail.com> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
* Rename "solid" to "structure" * Rename all abstract types to `Abstract*` * Rename "fixed particles" to "clamped particles" * Rename `BoundaryMovement` to `PrescribedMotion` * Reformat * Fix docs * Fix tests * Fix docs * Fix tests * Fix merge * Implement suggestions * Export `AbstractDensityDiffusion` * Link to unexported `AbstractDensityDiffusion` * Fix
* Rename `BoundarySPHSystem` and `OpenBoundarySPHSystem` * Reformat * Update NEWS.md * Fix tests * Rename kwarg * Update docs * Reformat * Fix * Fix example files * Reformat * Implement suggestions
* Rename `each_moving_particle`, `n_moving_particles` and `active_particles` * Reformat * Update NEWS.md
* Restructure boundary files * Fix doctests * Reformat
…#909) * Make `PrescribedMotion` more powerful by passing the initial position * Update NEWS.md * Move `SVector` warning to `WallBoundarySystem` constructor * Extract `initialize!` function * Move constructor of `PrescribedMotion` further up * Update prescribed_motion.jl Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com> --------- Co-authored-by: Niklas Neher <73897120+LasNikas@users.noreply.github.com>
* make edac consistent with wcsph * fix tests * formatting * fix tests * fix * fix `atol` in dam break validation * implement suggestions --------- Co-authored-by: LasNikas <niklas.nehe@web.de>
* add oriented bounding box * fix * fix * fix * fix default lib dependency * add tests and docs * add test data * try to fix docs * implement suggestions * fix docs * rename `plane` to `boundary_face` * fix tests `boundary_face` * add doc test * fix doc tests * fix unit tests * rename `plane_normal` to `face_normal` * rename parameter type * apply formatter * add NEWS entry * implement suggerstions * update NEWS --------- Co-authored-by: LasNikas <niklas.nehe@web.de> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
* fix gpu * rm saving callback * implement suggestions * rm solution_saving=nothing --------- Co-authored-by: LasNikas <niklas.nehe@web.de> Co-authored-by: Erik Faulhaber <44124897+efaulhaber@users.noreply.github.com>
efaulhaber
previously approved these changes
Sep 19, 2025
Member
|
/run-gpu-tests |
Member
|
/run-gpu-tests |
efaulhaber
approved these changes
Sep 19, 2025
auto-merge was automatically disabled
September 19, 2025 11:17
Merge commits are not allowed on this repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tlsphtoplace_on_shelldvdu_odevector tocustom_quantities#879