Skip to content

Packing tutorial#847

Merged
svchb merged 24 commits intotrixi-framework:mainfrom
LasNikas:packing-tutorial
Aug 1, 2025
Merged

Packing tutorial#847
svchb merged 24 commits intotrixi-framework:mainfrom
LasNikas:packing-tutorial

Conversation

@LasNikas
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 26, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.37%. Comparing base (6b43656) to head (3a8c3fe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/visualization/recipes_plots.jl 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   70.48%   70.37%   -0.12%     
==========================================
  Files         106      106              
  Lines        7031     7042      +11     
==========================================
  Hits         4956     4956              
- Misses       2075     2086      +11     
Flag Coverage Δ
unit 70.37% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas LasNikas marked this pull request as ready for review June 30, 2025 15:36
@LasNikas LasNikas requested review from efaulhaber and svchb June 30, 2025 15:36
@LasNikas LasNikas self-assigned this Jun 30, 2025
@LasNikas LasNikas added the documentation Improvements or additions to documentation label Jun 30, 2025
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is getting to long. I will continue at "Create initial configuration of interior particles".

Comment thread docs/src/preprocessing/preprocessing.md
Comment thread src/setups/complex_shape.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread src/visualization/recipes_plots.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl
@LasNikas LasNikas requested a review from efaulhaber July 15, 2025 13:13
Copy link
Copy Markdown
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stopped at the Particle Packing section

Comment thread docs/make.jl
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/literate/src/tut_packing.jl Outdated
Comment thread docs/src/preprocessing/preprocessing.md
Comment thread src/visualization/recipes_plots.jl Outdated
@LasNikas LasNikas requested review from efaulhaber and svchb July 31, 2025 12:17
efaulhaber
efaulhaber previously approved these changes Jul 31, 2025
@LasNikas
Copy link
Copy Markdown
Collaborator Author

/run-gpu-tests

Comment thread docs/literate/src/tut_packing.jl Outdated
@svchb svchb enabled auto-merge (squash) August 1, 2025 09:56
@LasNikas
Copy link
Copy Markdown
Collaborator Author

LasNikas commented Aug 1, 2025

/run-gpu-tests

@svchb svchb merged commit c9bb1ae into trixi-framework:main Aug 1, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants