Skip to content

Avoid atomic_cas in open boundaries and add gpu tests#849

Merged
efaulhaber merged 13 commits intotrixi-framework:mainfrom
LasNikas:thread-save-open-boundaries
Jul 14, 2025
Merged

Avoid atomic_cas in open boundaries and add gpu tests#849
efaulhaber merged 13 commits intotrixi-framework:mainfrom
LasNikas:thread-save-open-boundaries

Conversation

@LasNikas
Copy link
Copy Markdown
Collaborator

@LasNikas LasNikas commented Jul 1, 2025

No description provided.

@LasNikas LasNikas requested review from efaulhaber and svchb July 1, 2025 08:08
@LasNikas LasNikas self-assigned this Jul 1, 2025
@LasNikas LasNikas added the gpu label Jul 1, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 15.15152% with 28 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (c9069f1) to head (fa96884).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/schemes/boundary/open_boundary/system.jl 7.14% 26 Missing ⚠️
test/general/buffer.jl 0.00% 1 Missing ⚠️
test/systems/open_boundary_system.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   70.47%   70.25%   -0.22%     
==========================================
  Files         106      106              
  Lines        6893     6906      +13     
==========================================
- Hits         4858     4852       -6     
- Misses       2035     2054      +19     
Flag Coverage Δ
unit 70.25% <15.15%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas
Copy link
Copy Markdown
Collaborator Author

LasNikas commented Jul 1, 2025

/run-gpu-tests

Comment thread src/general/buffer.jl
@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Jul 3, 2025

/run-gpu-tests

Comment thread src/schemes/boundary/open_boundary/system.jl Outdated
Comment thread src/schemes/boundary/open_boundary/system.jl Outdated
Comment thread test/examples/gpu.jl
Comment thread test/general/buffer.jl Outdated
@LasNikas LasNikas requested a review from efaulhaber July 14, 2025 12:31
@LasNikas
Copy link
Copy Markdown
Collaborator Author

/run-gpu-tests

efaulhaber
efaulhaber previously approved these changes Jul 14, 2025
@efaulhaber efaulhaber enabled auto-merge (squash) July 14, 2025 12:41
@LasNikas
Copy link
Copy Markdown
Collaborator Author

/run-gpu-tests

@efaulhaber efaulhaber merged commit 3cb59d4 into trixi-framework:main Jul 14, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants