Skip to content

Fix Adami boundary viscosity#853

Merged
LasNikas merged 6 commits intotrixi-framework:mainfrom
efaulhaber:fix-adami-boundary-viscosity
Jul 23, 2025
Merged

Fix Adami boundary viscosity#853
LasNikas merged 6 commits intotrixi-framework:mainfrom
efaulhaber:fix-adami-boundary-viscosity

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber commented Jul 1, 2025

When using AdamiPressureExtrapolation, the velocity extrapolation was passing system_coords instead of v to current_velocity. This argument wasn't used for boundary systems, but for TLSPH, it did not work correctly.

This is on main:
grafik
The boundary layer is clearly smaller at the blade of the fin on the right, which is the integrated TLSPH part. The left are fixed particles, so wall viscosity is working correctly.

This PR:
grafik

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (cebef0c) to head (fcf780c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   70.38%   70.46%   +0.08%     
==========================================
  Files         106      106              
  Lines        6894     6894              
==========================================
+ Hits         4852     4858       +6     
+ Misses       2042     2036       -6     
Flag Coverage Δ
unit 70.46% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Jul 2, 2025

Can you add a test for compute_adami_density and compute_wall_velocity?

@efaulhaber
Copy link
Copy Markdown
Member Author

Done.

Comment thread test/schemes/boundary/dummy_particles/dummy_particles.jl
@efaulhaber efaulhaber self-assigned this Jul 22, 2025
@efaulhaber efaulhaber added the bug Something isn't working label Jul 22, 2025
@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Jul 23, 2025

/run-gpu-tests

@LasNikas LasNikas enabled auto-merge (squash) July 23, 2025 08:12
@LasNikas LasNikas merged commit ac2acd2 into trixi-framework:main Jul 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants