Fix SWME flux function#161
Open
patrickersing wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 105 105
Lines 5565 5565
=======================================
Hits 5424 5424
Misses 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
The coveralls upload is currently failing on MacOS. This should get fixed in #162. |
andrewwinters5000
approved these changes
Jul 6, 2026
andrewwinters5000
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
fluxfunction for theShallowWaterMomentEquations, which was missing a multiplication by the water heighth.This should have been covered by unit testing, but since we chose
u = SVector(1.0, 0.3, 0.15, 0.15, 0.1), the test did not fail. I have changed the test values to avoid this problem.