Skip to content

Fix SWME flux function#161

Open
patrickersing wants to merge 2 commits into
trixi-framework:mainfrom
patrickersing:fix_swme_flux
Open

Fix SWME flux function#161
patrickersing wants to merge 2 commits into
trixi-framework:mainfrom
patrickersing:fix_swme_flux

Conversation

@patrickersing

Copy link
Copy Markdown
Member

This fixes a bug in the flux function for the ShallowWaterMomentEquations, which was missing a multiplication by the water height h.

This should have been covered by unit testing, but since we chose u = SVector(1.0, 0.3, 0.15, 0.15, 0.1), the test did not fail. I have changed the test values to avoid this problem.

@patrickersing patrickersing added the bug Something isn't working label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (58fc7b9) to head (1fd055e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         105      105           
  Lines        5565     5565           
=======================================
  Hits         5424     5424           
  Misses        141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@patrickersing

Copy link
Copy Markdown
Member Author

The coveralls upload is currently failing on MacOS. This should get fixed in #162.

@andrewwinters5000 andrewwinters5000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants