Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 95.62% 96.15% +0.52%
==========================================
Files 23 25 +2
Lines 1097 1273 +176
Branches 63 74 +11
==========================================
+ Hits 1049 1224 +175
- Misses 44 45 +1
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sloede
reviewed
Sep 25, 2025
Member
sloede
left a comment
There was a problem hiding this comment.
Very nice extension, I just have two naming suggestions/comments
sloede
approved these changes
Oct 9, 2025
Member
sloede
left a comment
There was a problem hiding this comment.
I did only a cursory check since it seems to be a lot of regex search and replace. But after this, I think a new breaking release would be in order :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new methods
trixi_load_conservative_varsandtrixi_save_conservative_varsto read and write conservative variables by copying data. Moreover, a methodtrixi_get_data_pointeris added, which returns a pointer to Trixi's internal simulation data array. Thus no data needs to be copied, but it is potentially more risky.Both approaches can be used to modify the conservative variables. This is demonstrated by changing the concentration of a passive tracer during a simulation.