Skip to content
This repository was archived by the owner on Sep 6, 2025. It is now read-only.

Commit 3bc4021

Browse files
azakhiazakhi
authored
Convert relevant id references to long (#77)
* Fix header names for rate limiting * Change Action ResourceId to long * Convert all relevant id references to long
1 parent ffe451c commit 3bc4021

39 files changed

Lines changed: 147 additions & 147 deletions

‎DigitalOcean.API.Tests/Clients/ActionsClientTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public void CorrectRequestForGet() {
1515

1616
actionClient.Get(9001);
1717

18-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
18+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
1919
factory.Received().ExecuteRequest<Action>("actions/{id}", parameters, null, "action");
2020
}
2121

‎DigitalOcean.API.Tests/Clients/DomainRecordsClientTest.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void CorrectRequestForGet() {
4242
domainClient.Get("vevix.net", 9001);
4343

4444
var parameters = Arg.Is<List<Parameter>>(list =>
45-
(string)list[0].Value == "vevix.net" && (int)list[1].Value == 9001);
45+
(string)list[0].Value == "vevix.net" && (long)list[1].Value == 9001);
4646
factory.Received()
4747
.ExecuteRequest<DomainRecord>("domains/{name}/records/{id}", parameters,
4848
null, "domain_record");
@@ -56,7 +56,7 @@ public void CorrectRequestForDelete() {
5656
domainClient.Delete("vevix.net", 9001);
5757

5858
var parameters = Arg.Is<List<Parameter>>(list =>
59-
(string)list[0].Value == "vevix.net" && (int)list[1].Value == 9001);
59+
(string)list[0].Value == "vevix.net" && (long)list[1].Value == 9001);
6060
factory.Received().ExecuteRaw("domains/{name}/records/{id}", parameters, null, Method.DELETE);
6161
}
6262

@@ -69,7 +69,7 @@ public void CorrectRequestForUpdate() {
6969
domainClient.Update("vevix.net", 9001, data);
7070

7171
var parameters = Arg.Is<List<Parameter>>(list =>
72-
(string)list[0].Value == "vevix.net" && (int)list[1].Value == 9001);
72+
(string)list[0].Value == "vevix.net" && (long)list[1].Value == 9001);
7373
factory.Received().ExecuteRequest<DomainRecord>(
7474
"domains/{name}/records/{id}", parameters, data, "domain_record", Method.PUT);
7575
}

‎DigitalOcean.API.Tests/Clients/DropletActionsClientTest.cs‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public void CorrectRequestForReboot() {
1616

1717
client.Reboot(9001);
1818

19-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
19+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
2020
var body = Arg.Is<DropletAction>(action => action.Type == "reboot");
2121
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
2222
parameters, body, "action", Method.POST);
@@ -29,7 +29,7 @@ public void CorrectRequestForPowerCycle() {
2929

3030
client.PowerCycle(9001);
3131

32-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
32+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
3333
var body = Arg.Is<DropletAction>(action => action.Type == "power_cycle");
3434
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
3535
parameters, body, "action", Method.POST);
@@ -42,7 +42,7 @@ public void CorrectRequestForShutdown() {
4242

4343
client.Shutdown(9001);
4444

45-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
45+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
4646
var body = Arg.Is<DropletAction>(action => action.Type == "shutdown");
4747
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
4848
parameters, body, "action", Method.POST);
@@ -55,7 +55,7 @@ public void CorrectRequestForPowerOff() {
5555

5656
client.PowerOff(9001);
5757

58-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
58+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
5959
var body = Arg.Is<DropletAction>(action => action.Type == "power_off");
6060
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
6161
parameters, body, "action", Method.POST);
@@ -68,7 +68,7 @@ public void CorrectRequestForPowerOn() {
6868

6969
client.PowerOn(9001);
7070

71-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
71+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
7272
var body = Arg.Is<DropletAction>(action => action.Type == "power_on");
7373
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
7474
parameters, body, "action", Method.POST);
@@ -81,7 +81,7 @@ public void CorrectRequestForResetPassword() {
8181

8282
client.ResetPassword(9001);
8383

84-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
84+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
8585
var body = Arg.Is<DropletAction>(action => action.Type == "password_reset");
8686
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
8787
parameters, body, "action", Method.POST);
@@ -94,7 +94,7 @@ public void CorrectRequestForResize() {
9494

9595
client.Resize(9001, "1024mb", true);
9696

97-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
97+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
9898
var body = Arg.Is<DropletAction>(action => action.Type == "resize" && action.Size == "1024mb" && action.Disk == true);
9999
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
100100
parameters, body, "action", Method.POST);
@@ -105,10 +105,10 @@ public void CorrectRequestForRestore() {
105105
var factory = Substitute.For<IConnection>();
106106
var client = new DropletActionsClient(factory);
107107

108-
client.Restore(9001, 1009);
108+
client.Restore(9001, 1009L);
109109

110-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
111-
var body = Arg.Is<DropletAction>(action => action.Type == "restore" && (int)action.Image == 1009);
110+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
111+
var body = Arg.Is<DropletAction>(action => action.Type == "restore" && (long)action.Image == 1009);
112112
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
113113
parameters, body, "action", Method.POST);
114114
}
@@ -118,10 +118,10 @@ public void CorrectRequestForRebuild() {
118118
var factory = Substitute.For<IConnection>();
119119
var client = new DropletActionsClient(factory);
120120

121-
client.Rebuild(9001, 1009);
121+
client.Rebuild(9001, 1009L);
122122

123-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
124-
var body = Arg.Is<DropletAction>(action => action.Type == "rebuild" && (int)action.Image == 1009);
123+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
124+
var body = Arg.Is<DropletAction>(action => action.Type == "rebuild" && (long)action.Image == 1009);
125125
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
126126
parameters, body, "action", Method.POST);
127127
}
@@ -133,7 +133,7 @@ public void CorrectRequestForRename() {
133133

134134
client.Rename(9001, "testing");
135135

136-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
136+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
137137
var body = Arg.Is<DropletAction>(action => action.Type == "rename" && action.Name == "testing");
138138
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
139139
parameters, body, "action", Method.POST);
@@ -146,7 +146,7 @@ public void CorrectRequestForKernel() {
146146

147147
client.ChangeKernel(9001, 1009);
148148

149-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
149+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
150150
var body = Arg.Is<DropletAction>(action => action.Type == "change_kernel" && action.KernelId == 1009);
151151
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
152152
parameters, body, "action", Method.POST);
@@ -159,7 +159,7 @@ public void CorrectRequestForIpv6() {
159159

160160
client.EnableIpv6(9001);
161161

162-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
162+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
163163
var body = Arg.Is<DropletAction>(action => action.Type == "enable_ipv6");
164164
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
165165
parameters, body, "action", Method.POST);
@@ -172,7 +172,7 @@ public void CorrectRequestForEnableBackups() {
172172

173173
client.EnableBackups(9001);
174174

175-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
175+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
176176
var body = Arg.Is<DropletAction>(action => action.Type == "enable_backups");
177177
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
178178
parameters, body, "action", Method.POST);
@@ -185,7 +185,7 @@ public void CorrectRequestForDisableBackups() {
185185

186186
client.DisableBackups(9001);
187187

188-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
188+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
189189
var body = Arg.Is<DropletAction>(action => action.Type == "disable_backups");
190190
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
191191
parameters, body, "action", Method.POST);
@@ -198,7 +198,7 @@ public void CorrectRequestForPrivateNetworking() {
198198

199199
client.EnablePrivateNetworking(9001);
200200

201-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
201+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
202202
var body = Arg.Is<DropletAction>(action => action.Type == "enable_private_networking");
203203
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
204204
parameters, body, "action", Method.POST);
@@ -211,7 +211,7 @@ public void CorrectRequestForSnapshot() {
211211

212212
client.Snapshot(9001, "testing");
213213

214-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
214+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
215215
var body = Arg.Is<DropletAction>(action => action.Type == "snapshot" && action.Name == "testing");
216216
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions",
217217
parameters, body, "action", Method.POST);
@@ -224,8 +224,8 @@ public void CorrectRequestForGetAction() {
224224

225225
client.GetDropletAction(9001, 1009);
226226

227-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001 &&
228-
(int)list[1].Value == 1009);
227+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001 &&
228+
(long)list[1].Value == 1009);
229229
factory.Received().ExecuteRequest<Models.Responses.Action>("droplets/{dropletId}/actions/{actionId}",
230230
parameters, null, "action");
231231
}

‎DigitalOcean.API.Tests/Clients/DropletsClientTest.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public void CorrectRequestForGetAllNeighbors() {
3636

3737
client.GetAllNeighbors(9001);
3838

39-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
39+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
4040
factory.Received().GetPaginated<Droplet>("droplets/{id}/neighbors", parameters, "droplets");
4141
}
4242

@@ -47,7 +47,7 @@ public void CorrectRequestForGetKernels() {
4747

4848
client.GetKernels(9001);
4949

50-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
50+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
5151
factory.Received().GetPaginated<Kernel>("droplets/{id}/kernels", parameters, "kernels");
5252
}
5353

@@ -58,7 +58,7 @@ public void CorrectRequestForGetSnapshots() {
5858

5959
client.GetSnapshots(9001);
6060

61-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
61+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
6262
factory.Received().GetPaginated<Image>("droplets/{id}/snapshots", parameters, "snapshots");
6363
}
6464

@@ -69,7 +69,7 @@ public void CorrectRequestForGetBackups() {
6969

7070
client.GetBackups(9001);
7171

72-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
72+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
7373
factory.Received().GetPaginated<Image>("droplets/{id}/backups", parameters, "backups");
7474
}
7575

@@ -80,7 +80,7 @@ public void CorrectRequestForGetActions() {
8080

8181
client.GetActions(9001);
8282

83-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
83+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
8484
factory.Received().GetPaginated<Action>("droplets/{id}/actions", parameters, "actions");
8585
}
8686

@@ -113,7 +113,7 @@ public void CorrectRequestForGet() {
113113

114114
client.Get(9001);
115115

116-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
116+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
117117
factory.Received().ExecuteRequest<Droplet>("droplets/{id}", parameters, null, "droplet");
118118
}
119119

@@ -124,7 +124,7 @@ public void CorrectRequestForDelete() {
124124

125125
client.Delete(9001);
126126

127-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
127+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
128128
factory.Received().ExecuteRaw("droplets/{id}", parameters, null, Method.DELETE);
129129
}
130130

‎DigitalOcean.API.Tests/Clients/FirewallsClientTest.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void CorrectRequestForAddDroplets() {
5959
var factory = Substitute.For<IConnection>();
6060
var client = new FirewallsClient(factory);
6161
var droplets = new Models.Requests.FirewallDroplets {
62-
DropletIds = new List<int> { 1, 2, 3, 4 }
62+
DropletIds = new List<long> { 1, 2, 3, 4 }
6363
};
6464
client.AddDroplets("1", droplets);
6565
var parameters = Arg.Is<List<Parameter>>(list => (string)list[0].Value == "1");
@@ -71,7 +71,7 @@ public void CorrectRequestForRemoveDroplets() {
7171
var factory = Substitute.For<IConnection>();
7272
var client = new FirewallsClient(factory);
7373
var droplets = new Models.Requests.FirewallDroplets {
74-
DropletIds = new List<int> { 1, 2, 3, 4 }
74+
DropletIds = new List<long> { 1, 2, 3, 4 }
7575
};
7676
client.RemoveDroplets("1", droplets);
7777
var parameters = Arg.Is<List<Parameter>>(list => (string)list[0].Value == "1");

‎DigitalOcean.API.Tests/Clients/FloatingIpActionsTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void CorrectRequestForAction() {
4848

4949
client.GetAction("1.2.3.4", 100);
5050
var parameters = Arg.Is<List<Parameter>>(list =>
51-
(string)list[0].Value == "1.2.3.4" && (int)list[1].Value == 100);
51+
(string)list[0].Value == "1.2.3.4" && (long)list[1].Value == 100);
5252
factory.Received().ExecuteRequest<Action>("floating_ips/{ip}/actions/{actionId}", parameters, null, "action");
5353
}
5454
}

‎DigitalOcean.API.Tests/Clients/ImageActionsClientTest.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public void CorrectRequestForTransfer() {
1515

1616
client.Transfer(9001, "sfo1");
1717

18-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
18+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
1919
var body = Arg.Is<ImageAction>(action => action.Type == "transfer" && action.Region == "sfo1");
2020
factory.Received().ExecuteRequest<Models.Responses.Action>("images/{imageId}/actions",
2121
parameters, body, "action", Method.POST);
@@ -28,7 +28,7 @@ public void CorrectRequestForConvert() {
2828

2929
client.Convert(9001);
3030

31-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
31+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
3232
var body = Arg.Is<ImageAction>(action => action.Type == "convert");
3333
factory.Received().ExecuteRequest<Models.Responses.Action>("images/{imageId}/actions",
3434
parameters, body, "action", Method.POST);
@@ -41,8 +41,8 @@ public void CorrectRequestForGetAction() {
4141

4242
client.GetAction(9001, 1009);
4343

44-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001 &&
45-
(int)list[1].Value == 1009);
44+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001 &&
45+
(long)list[1].Value == 1009);
4646
factory.Received().ExecuteRequest<Models.Responses.Action>("images/{imageId}/actions/{actionId}",
4747
parameters, null, "action");
4848
}

‎DigitalOcean.API.Tests/Clients/ImagesClientTest.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void CorrectRequestForGetAllActions() {
4646

4747
client.GetAllActions(9001);
4848

49-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
49+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
5050
factory.Received().GetPaginated<Action>("images/{id}/actions", parameters, "actions");
5151
}
5252

@@ -66,9 +66,9 @@ public void CorrectRequestForGetId() {
6666
var factory = Substitute.For<IConnection>();
6767
var client = new ImagesClient(factory);
6868

69-
client.Get(9001);
69+
client.Get(9001L);
7070

71-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
71+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
7272
factory.Received().ExecuteRequest<Image>("images/{id}", parameters, null, "image");
7373
}
7474

@@ -90,7 +90,7 @@ public void CorrectRequestForDelete() {
9090

9191
client.Delete(9001);
9292

93-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
93+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
9494
factory.Received().ExecuteRaw("images/{id}", parameters, null, Method.DELETE);
9595
}
9696

@@ -102,7 +102,7 @@ public void CorrectRequestForUpdate() {
102102
var body = new Models.Requests.UpdateImage { Name = "example" };
103103
client.Update(9001, body);
104104

105-
var parameters = Arg.Is<List<Parameter>>(list => (int)list[0].Value == 9001);
105+
var parameters = Arg.Is<List<Parameter>>(list => (long)list[0].Value == 9001);
106106
factory.Received().ExecuteRequest<Image>("images/{id}", parameters, body, "image", Method.PUT);
107107
}
108108
}

0 commit comments

Comments
 (0)