Commit 0aebaff
fix(plugins): declare missing :crypto and :common jar deps for binaryRelease
Per review on PR #6738 (halibobo1205): the binaryRelease Jar task zips up
runtimeClasspath contents, which on this branch includes :crypto:jar and
:common:jar (introduced by #6637), but the task only declared dependsOn on
:protocol:jar and :platform:jar. Gradle was emitting an implicit_dependency
warning and disabling execution optimizations to compensate.
Reproduced locally:
$ ./gradlew clean && ./gradlew :plugins:buildToolkitJar
> Cannot expand ZIP '.../crypto/build/libs/crypto-1.0.0.jar' as it does
not exist.
Add :crypto:jar and :common:jar to dependsOn so partial / parallel /
incremental builds can no longer race against missing dependency jars.
Verified:
- ./gradlew clean :plugins:buildToolkitJar passes with --warning-mode all
and no implicit_dependency warning
- Smoke (db archive -d <empty>) still exits 0 on x86 docker
- :plugins:test, checkstyleMain, checkstyleTest all pass1 parent 69d7f21 commit 0aebaff
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
145 | 151 | | |
146 | 152 | | |
147 | 153 | | |
| |||
0 commit comments