remove redundant check

Author: Federico2014

framework/src/main/java/org/tron/core/Wallet.java

@@ -1806,12 +1806,8 @@ public Exchange getExchangeById(ByteString exchangeId) {
     return null;
   }
 
-  private boolean getAllowShieldedTransactionApi() {
-    return Args.getInstance().isAllowShieldedTransactionApi();
-  }
-
   private void checkAllowShieldedTransactionApi() throws ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
+    if (!Args.getInstance().isAllowShieldedTransactionApi()) {
       throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
     }
   }
@@ -1830,10 +1826,7 @@ public BytesMessage getNullifier(ByteString id) {
   }
 
   private long getBlockNumber(OutputPoint outPoint)
-      throws BadItemException, ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
-      throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
-    }
+      throws BadItemException {
     ByteString txId = outPoint.getHash();
 
     long blockNum = chainBaseManager.getTransactionStore().getBlockNumber(txId.toByteArray());
@@ -1848,9 +1841,6 @@ private long getBlockNumber(OutputPoint outPoint)
   private IncrementalMerkleVoucherContainer createWitness(OutputPoint outPoint, Long blockNumber)
       throws ItemNotFoundException, BadItemException,
       InvalidProtocolBufferException, ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
-      throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
-    }
     ByteString txId = outPoint.getHash();
 
     //Get the tree in blockNum-1 position
@@ -1946,9 +1936,6 @@ private IncrementalMerkleVoucherContainer createWitness(OutputPoint outPoint, Lo
   private void updateWitnesses(List<IncrementalMerkleVoucherContainer> witnessList, long large,
       int synBlockNum) throws ItemNotFoundException, BadItemException,
       InvalidProtocolBufferException, ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
-      throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
-    }
     long start = large;
     long end = large + synBlockNum - 1;
 
@@ -2022,10 +2009,7 @@ private void updateLowWitness(IncrementalMerkleVoucherContainer witness, long bl
     }
   }
 
-  private void validateInput(OutputPointInfo request) throws BadItemException, ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
-      throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
-    }
+  private void validateInput(OutputPointInfo request) throws BadItemException {
     if (request.getBlockNum() < 0 || request.getBlockNum() > 1000) {
       throw new BadItemException("request.BlockNum must be specified with range in [0, 1000]");
     }
@@ -2097,9 +2081,7 @@ public IncrementalMerkleVoucherInfo getMerkleTreeVoucherInfo(OutputPointInfo req
   }
 
   public IncrementalMerkleTree getMerkleTreeOfBlock(long blockNum) throws ZksnarkException {
-    if (!getAllowShieldedTransactionApi()) {
-      throw new ZksnarkException(SHIELDED_ID_NOT_ALLOWED);
-    }
+    checkAllowShieldedTransactionApi();
     if (blockNum < 0) {
       return null;
     }

framework/src/main/java/org/tron/core/zen/ZksnarkInitService.java

@@ -3,6 +3,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.util.concurrent.atomic.AtomicBoolean;
 import javax.annotation.PostConstruct;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.io.FileUtils;
@@ -16,12 +17,19 @@
 @Component
 public class ZksnarkInitService {
 
+  private static final AtomicBoolean initialized = new AtomicBoolean(false);
+
   @PostConstruct
   private void init() {
     librustzcashInitZksnarkParams();
   }
 
   public static void librustzcashInitZksnarkParams() {
+    if (initialized.get()) {
+      logger.info("zk param already initialized");
+      return;
+    }
+
     logger.info("init zk param begin");
 
     String spendPath = getParamsFile("sapling-spend.params");
@@ -35,6 +43,7 @@ public static void librustzcashInitZksnarkParams() {
     try {
       JLibrustzcash.librustzcashInitZksnarkParams(
           new LibrustzcashParam.InitZksnarkParams(spendPath, spendHash, outputPath, outputHash));
+      initialized.set(true);
     } catch (ZksnarkException e) {
       throw new TronError(e, TronError.ErrCode.ZCASH_INIT);
     }