Commit 320da62
fix(plugins): revert zksnark/commons-io alignment, document why
CI on rockylinux (x86_64 + JDK 8) failed under 0aebaff:
org.tron.plugins.rocksdb.DbLiteRocksDbTest > testToolsWithRocksDB FAILED
org.springframework.beans.factory.BeanCreationException: Error creating
bean with name 'zksnarkInitService' ... NoClassDefFoundError:
org/apache/commons/io/FileUtils
After commit 69d7f21 mirrored the :platform excludes onto :crypto
(reviewer's option A in #6738), x86 testRuntimeClasspath lost
commons-io:commons-io and io.github.tronprotocol:zksnark-java-sdk
entirely: both arrived only via :crypto -> :common -> :platform, which
is now also excluding them. ARM64 was unaffected because the ARM64
branch declares :platform without exclusions.
Diagnosis: the DbLiteTest Spring boot path loads
org.tron.core.zen.ZksnarkInitService, which references both
org.apache.commons.io.FileUtils and
org.tron.common.zksnark.LibrustzcashWrapper at runtime. Reproduced on
x86_64 docker:
- removing only commons-io exclude -> FAILED at LibrustzcashWrapper
- removing both exclusions -> testToolsWithRocksDB PASSED
The :platform-side excludes for these two artifacts are therefore
deduplication only, not a "kept out of plugins" intent. The
leveldbjni-all exclude is the only one that must be mirrored, because
that one is the actual classpath conflict.
This commit drops the zksnark-java-sdk and commons-io excludes from
:crypto and adds a comment recording why they are intentionally
asymmetric with :platform.
Verified on x86_64 + JDK 8 (eclipse-temurin:8-jdk):
- :plugins:test passes (was 4 failed under 0aebaff)
- runtimeClasspath still does NOT contain leveldbjni-all 1.8
- runtimeClasspath now contains commons-io and zksnark-java-sdk
- Toolkit.jar smoke (db archive -d <empty>) still exits 01 parent 0aebaff commit 320da62
1 file changed
Lines changed: 12 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
49 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
50 | 55 | | |
51 | | - | |
52 | | - | |
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
| |||
0 commit comments