test(framework): replace Assert.fail with throws Exception in test methods

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Little-Peony

framework/src/test/java/org/tron/common/utils/PropUtilTest.java

@@ -1,21 +1,16 @@
 package org.tron.common.utils;
 
 import java.io.File;
-import java.io.IOException;
 import org.junit.Assert;
 import org.junit.Test;
 
 public class PropUtilTest {
 
   @Test
-  public void testWriteProperty() {
+  public void testWriteProperty() throws Exception {
     String filename = "test_prop.properties";
     File file = new File(filename);
-    try {
-      file.createNewFile();
-    } catch (IOException e) {
-      Assert.fail(e.getMessage());
-    }
+    file.createNewFile();
     PropUtil.writeProperty(filename, "key", "value");
     Assert.assertTrue("value".equals(PropUtil.readProperty(filename, "key")));
     PropUtil.writeProperty(filename, "key", "value2");
@@ -24,14 +19,10 @@ public void testWriteProperty() {
   }
 
   @Test
-  public void testReadProperty() {
+  public void testReadProperty() throws Exception {
     String filename = "test_prop.properties";
     File file = new File(filename);
-    try {
-      file.createNewFile();
-    } catch (IOException e) {
-      Assert.fail(e.getMessage());
-    }
+    file.createNewFile();
     PropUtil.writeProperty(filename, "key", "value");
     Assert.assertTrue("value".equals(PropUtil.readProperty(filename, "key")));
     file.delete();

framework/src/test/java/org/tron/core/db/BlockStoreTest.java

@@ -10,8 +10,6 @@
 import org.tron.common.utils.Sha256Hash;
 import org.tron.core.capsule.BlockCapsule;
 import org.tron.core.config.args.Args;
-import org.tron.core.exception.BadItemException;
-import org.tron.core.exception.ItemNotFoundException;
 
 
 @Slf4j
@@ -35,56 +33,43 @@ public void testCreateBlockStore() {
   }
 
   @Test
-  public void testPut() {
+  public void testPut() throws Exception {
     long number = 1;
     BlockCapsule blockCapsule = getBlockCapsule(number);
 
     byte[] blockId = blockCapsule.getBlockId().getBytes();
     blockStore.put(blockId, blockCapsule);
-    try {
-      BlockCapsule blockCapsule1 = blockStore.get(blockId);
-      Assert.assertNotNull(blockCapsule1);
-      Assert.assertEquals(number, blockCapsule1.getNum());
-    } catch (ItemNotFoundException | BadItemException e) {
-      Assert.fail(e.getMessage());
-    }
+    BlockCapsule blockCapsule1 = blockStore.get(blockId);
+    Assert.assertNotNull(blockCapsule1);
+    Assert.assertEquals(number, blockCapsule1.getNum());
   }
 
   @Test
-  public void testGet() {
+  public void testGet() throws Exception {
     long number = 2;
     BlockCapsule blockCapsule = getBlockCapsule(number);
     byte[] blockId = blockCapsule.getBlockId().getBytes();
     blockStore.put(blockId, blockCapsule);
-    try {
-      boolean has = blockStore.has(blockId);
-      Assert.assertTrue(has);
-      BlockCapsule blockCapsule1 = blockStore.get(blockId);
-
-      Assert.assertEquals(number, blockCapsule1.getNum());
-    } catch (ItemNotFoundException | BadItemException e) {
-      Assert.fail(e.getMessage());
-    }
+    boolean has = blockStore.has(blockId);
+    Assert.assertTrue(has);
+    BlockCapsule blockCapsule1 = blockStore.get(blockId);
+    Assert.assertEquals(number, blockCapsule1.getNum());
   }
 
   @Test
-  public void testDelete() {
+  public void testDelete() throws Exception {
     long number = 1;
     BlockCapsule blockCapsule = getBlockCapsule(number);
 
     byte[] blockId = blockCapsule.getBlockId().getBytes();
     blockStore.put(blockId, blockCapsule);
-    try {
-      BlockCapsule blockCapsule1 = blockStore.get(blockId);
-      Assert.assertNotNull(blockCapsule1);
-      Assert.assertEquals(number, blockCapsule1.getNum());
+    BlockCapsule blockCapsule1 = blockStore.get(blockId);
+    Assert.assertNotNull(blockCapsule1);
+    Assert.assertEquals(number, blockCapsule1.getNum());
 
-      blockStore.delete(blockId);
-      BlockCapsule blockCapsule2 = blockStore.getUnchecked(blockId);
-      Assert.assertNull(blockCapsule2);
-    } catch (ItemNotFoundException | BadItemException e) {
-      Assert.fail(e.getMessage());
-    }
+    blockStore.delete(blockId);
+    BlockCapsule blockCapsule2 = blockStore.getUnchecked(blockId);
+    Assert.assertNull(blockCapsule2);
   }
 
 }

framework/src/test/java/org/tron/core/db2/SnapshotImplTest.java

@@ -38,7 +38,7 @@ protected void beforeDestroy() {
    * from: get key1 or key2, traverse 0 times
    */
   @Test
-  public void testMergeRoot() {
+  public void testMergeRoot() throws Exception {
     // linklist is: from -> root
     SnapshotRoot root = new SnapshotRoot(tronDatabase.getDb());
     //root.setOptimized(true);
@@ -68,7 +68,7 @@ public void testMergeRoot() {
    *
    */
   @Test
-  public void testMergeAhead() {
+  public void testMergeAhead() throws Exception {
 
     // linklist is: from2 -> from -> root
     SnapshotRoot root = new SnapshotRoot(tronDatabase.getDb());
@@ -136,7 +136,7 @@ public void testMergeAhead() {
    * from2: key1=>value1, key2=>value2, key3=>value32, key4=>value4
    */
   @Test
-  public void testMergeOverride() {
+  public void testMergeOverride() throws Exception {
     // linklist is: from2 -> from -> root
     SnapshotRoot root = new SnapshotRoot(tronDatabase.getDb());
     SnapshotImpl from = getSnapshotImplIns(root);
@@ -165,15 +165,11 @@ public void testMergeOverride() {
    * The constructor of SnapshotImpl is not public
    * so reflection is used to construct the object here.
    */
-  private SnapshotImpl getSnapshotImplIns(Snapshot snapshot) {
+  private SnapshotImpl getSnapshotImplIns(Snapshot snapshot) throws Exception {
     Class clazz = SnapshotImpl.class;
-    try {
-      Constructor constructor = clazz.getDeclaredConstructor(Snapshot.class);
-      constructor.setAccessible(true);
-      return (SnapshotImpl) constructor.newInstance(snapshot);
-    } catch (Exception e) {
-      throw new AssertionError(e);
-    }
+    Constructor constructor = clazz.getDeclaredConstructor(Snapshot.class);
+    constructor.setAccessible(true);
+    return (SnapshotImpl) constructor.newInstance(snapshot);
   }
 
 }