reduce the initZksnarkParams only once

Federico2014 · Federico2014 · commit 829b0cfc42c1 · 2025-07-08T10:54:55.000+08:00
diff --git a/framework/build.gradle b/framework/build.gradle
@@ -123,14 +123,22 @@ test {
         destinationFile = file("$buildDir/jacoco/jacocoTest.exec")
         classDumpDir = file("$buildDir/jacoco/classpathdumps")
     }
+
+    exclude '**/ShieldedTRC20BuilderTest.class'
+    exclude '**/PrecompiledContractsVerifyProofTest.class'
+    exclude '**/ShieldedTransferActuatorTest.class'
+    exclude '**/ShieldWalletTest.class'
+    exclude '**/LibrustzcashTest.class'
+    exclude '**/SaplingNoteTest.class'
+    exclude '**/SendCoinShieldTest.class'
+    exclude '**/ShieldedReceiveTest.class'
+
     if (isWindows()) {
-        exclude '**/ShieldedTransferActuatorTest.class'
         exclude '**/BackupDbUtilTest.class'
         exclude '**/ManagerTest.class'
         exclude 'org/tron/core/zksnark/**'
-        exclude 'org/tron/common/runtime/vm/PrecompiledContractsVerifyProofTest.class'
-        exclude 'org/tron/core/ShieldedTRC20BuilderTest.class'
         exclude 'org/tron/common/runtime/vm/WithdrawRewardTest.class'
+        exclude 'org/tron/core/ZkSnarkTestsSuite.class'
     }
     maxHeapSize = "1024m"
     doFirst {
diff --git a/framework/src/test/java/org/tron/common/BaseTest.java b/framework/src/test/java/org/tron/common/BaseTest.java
@@ -26,6 +26,7 @@
 import org.tron.core.db.Manager;
 import org.tron.core.exception.BalanceInsufficientException;
 import org.tron.core.store.AccountStore;
+import org.tron.core.zen.ZksnarkInitService;
 import org.tron.protos.Protocol;
 
 @Slf4j
@@ -47,7 +48,6 @@ public abstract class BaseTest {
 
   private static Application appT1;
 
-
   @PostConstruct
   private void prepare() {
     appT1 = appT;
diff --git a/framework/src/test/java/org/tron/common/runtime/vm/PrecompiledContractsVerifyProofTest.java b/framework/src/test/java/org/tron/common/runtime/vm/PrecompiledContractsVerifyProofTest.java
@@ -41,11 +41,12 @@
 import org.tron.core.zen.address.PaymentAddress;
 import org.tron.core.zen.address.SpendingKey;
 import org.tron.core.zen.note.Note;
+import org.tron.core.zksnark.ZkSnarkTest;
 import org.tron.keystore.Wallet;
 import org.tron.protos.contract.ShieldContract;
 
 @Slf4j
-public class PrecompiledContractsVerifyProofTest extends BaseTest {
+public class PrecompiledContractsVerifyProofTest extends ZkSnarkTest {
 
   private static final String SHIELDED_CONTRACT_ADDRESS_STR = "TGAmX5AqVUoXCf8MoHxbuhQPmhGfWTnEgA";
   private static byte[] SHIELDED_CONTRACT_ADDRESS;
@@ -65,7 +66,6 @@ public static void init() {
         .fromHexString("030c8c2bc59fb3eb8afb047a8ea4b028743d23e7d38c6fa30908358431e2314d");
     SHIELDED_CONTRACT_ADDRESS = WalletClient.decodeFromBase58Check(SHIELDED_CONTRACT_ADDRESS_STR);
     PUBLIC_TO_ADDRESS = WalletClient.decodeFromBase58Check(PUBLIC_TO_ADDRESS_STR);
-    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   @Test
diff --git a/framework/src/test/java/org/tron/core/ShieldWalletTest.java b/framework/src/test/java/org/tron/core/ShieldWalletTest.java
@@ -2,7 +2,6 @@
 
 import static org.mockito.Mockito.doReturn;
 import static org.mockito.Mockito.spy;
-import static org.tron.core.zen.ZksnarkInitService.librustzcashInitZksnarkParams;
 
 import java.math.BigInteger;
 import javax.annotation.Resource;
@@ -15,25 +14,24 @@
 import org.tron.api.GrpcAPI.PrivateShieldedTRC20ParametersWithoutAsk;
 import org.tron.api.GrpcAPI.ShieldedAddressInfo;
 import org.tron.api.GrpcAPI.ShieldedTRC20Parameters;
-import org.tron.common.BaseTest;
 import org.tron.common.utils.ByteArray;
 import org.tron.core.capsule.TransactionCapsule;
 import org.tron.core.config.args.Args;
 import org.tron.core.exception.ContractExeException;
 import org.tron.core.exception.ContractValidateException;
 import org.tron.core.services.http.JsonFormat;
 import org.tron.core.services.http.JsonFormat.ParseException;
+import org.tron.core.zksnark.ZkSnarkTest;
 
 
-public class ShieldWalletTest extends BaseTest {
+public class ShieldWalletTest extends ZkSnarkTest {
 
   @Resource
   private Wallet wallet;
 
   @BeforeClass
   public static void init() {
     Args.setParam(new String[]{"-d", dbPath()}, Constant.TEST_CONF);
-    librustzcashInitZksnarkParams();
   }
 
   @Test
diff --git a/framework/src/test/java/org/tron/core/ShieldedTRC20BuilderTest.java b/framework/src/test/java/org/tron/core/ShieldedTRC20BuilderTest.java
@@ -47,11 +47,12 @@
 import org.tron.core.zen.address.PaymentAddress;
 import org.tron.core.zen.address.SpendingKey;
 import org.tron.core.zen.note.Note;
+import org.tron.core.zksnark.ZkSnarkTest;
 import org.tron.protos.contract.ShieldContract;
 import org.tron.protos.contract.ShieldContract.SpendDescription;
 
 @Slf4j
-public class ShieldedTRC20BuilderTest extends BaseTest {
+public class ShieldedTRC20BuilderTest extends ZkSnarkTest {
   @Resource
   private Wallet wallet;
   private String priKey = PublicMethod.getRandomPrivateKey();
@@ -73,11 +74,6 @@ public class ShieldedTRC20BuilderTest extends BaseTest {
   VerifyTransferProof transferContract = new VerifyTransferProof();
   VerifyBurnProof burnContract = new VerifyBurnProof();
 
-  @BeforeClass
-  public static void initZksnarkParams() {
-    ZksnarkInitService.librustzcashInitZksnarkParams();
-  }
-
   @Ignore
   @Test
   public void createShieldedContractParametersForMint()
diff --git a/framework/src/test/java/org/tron/core/ZkSnarkTestsSuite.java b/framework/src/test/java/org/tron/core/ZkSnarkTestsSuite.java
@@ -0,0 +1,25 @@
+package org.tron.core;
+
+import org.junit.runner.RunWith;
+import org.junit.runners.Suite;
+import org.tron.common.runtime.vm.PrecompiledContractsVerifyProofTest;
+import org.tron.core.actuator.ShieldedTransferActuatorTest;
+import org.tron.core.zksnark.LibrustzcashTest;
+import org.tron.core.zksnark.SaplingNoteTest;
+import org.tron.core.zksnark.SendCoinShieldTest;
+import org.tron.core.zksnark.ShieldedReceiveTest;
+
+@RunWith(Suite.class)
+@Suite.SuiteClasses({
+    ShieldedTRC20BuilderTest.class,
+    PrecompiledContractsVerifyProofTest.class,
+    ShieldedTransferActuatorTest.class,
+    ShieldWalletTest.class,
+    LibrustzcashTest.class,
+    SaplingNoteTest.class,
+    SendCoinShieldTest.class,
+    ShieldedReceiveTest.class
+})
+public class ZkSnarkTestsSuite {
+
+}
diff --git a/framework/src/test/java/org/tron/core/actuator/ShieldedTransferActuatorTest.java b/framework/src/test/java/org/tron/core/actuator/ShieldedTransferActuatorTest.java
@@ -36,14 +36,15 @@
 import org.tron.core.zen.address.PaymentAddress;
 import org.tron.core.zen.address.SpendingKey;
 import org.tron.core.zen.note.Note;
+import org.tron.core.zksnark.ZkSnarkTest;
 import org.tron.protos.Protocol.AccountType;
 import org.tron.protos.Protocol.Transaction.Contract;
 import org.tron.protos.contract.AssetIssueContractOuterClass.AssetIssueContract;
 import org.tron.protos.contract.ShieldContract.PedersenHash;
 import org.tron.protos.contract.ShieldContract.ShieldedTransferContract;
 
 @Slf4j
-public class ShieldedTransferActuatorTest extends BaseTest {
+public class ShieldedTransferActuatorTest extends ZkSnarkTest {
 
   private static final String PUBLIC_ADDRESS_ONE;
   private static final String ADDRESS_ONE_PRIVATE_KEY;
@@ -86,11 +87,6 @@ public class ShieldedTransferActuatorTest extends BaseTest {
   @BeforeClass
   public static void init() throws ZksnarkException {
     Args.getInstance().setAllowShieldedTransactionApi(true);
-    librustzcashInitZksnarkParams();
-  }
-
-  private static void librustzcashInitZksnarkParams() {
-    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   /**
diff --git a/framework/src/test/java/org/tron/core/zksnark/LibrustzcashTest.java b/framework/src/test/java/org/tron/core/zksnark/LibrustzcashTest.java
@@ -67,7 +67,7 @@
 import org.tron.protos.contract.ShieldContract.PedersenHash;
 
 @Slf4j
-public class LibrustzcashTest extends BaseTest {
+public class LibrustzcashTest extends ZkSnarkTest {
   private static final String dbDirectory = "db_Librustzcash_test";
   private static final String indexDirectory = "index_Librustzcash_test";
   @Resource
@@ -85,7 +85,6 @@ public static void init() {
         "config-test-mainnet.conf"
     );
     Args.getInstance().setAllowShieldedTransactionApi(true);
-    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   private static int randomInt(int minInt, int maxInt) {
diff --git a/framework/src/test/java/org/tron/core/zksnark/SaplingNoteTest.java b/framework/src/test/java/org/tron/core/zksnark/SaplingNoteTest.java
@@ -8,23 +8,23 @@
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.tron.common.utils.ByteArray;
+import org.tron.core.Constant;
 import org.tron.core.config.args.Args;
 import org.tron.core.exception.BadItemException;
 import org.tron.core.exception.ZksnarkException;
-import org.tron.core.zen.ZksnarkInitService;
 import org.tron.core.zen.address.DiversifierT;
 import org.tron.core.zen.address.PaymentAddress;
 import org.tron.core.zen.address.SpendingKey;
 import org.tron.core.zen.note.Note;
 
 
-public class SaplingNoteTest {
+public class SaplingNoteTest extends ZkSnarkTest {
 
   @BeforeClass
   public static void init() {
+    Args.setParam(new String[]{"-d", dbPath()}, Constant.TEST_CONF);
     Args.getInstance().setAllowShieldedTransactionApi(true);
     // Args.getInstance().setAllowShieldedTransaction(1);
-    ZksnarkInitService.librustzcashInitZksnarkParams();
   }
 
   @AfterClass
diff --git a/framework/src/test/java/org/tron/core/zksnark/SendCoinShieldTest.java b/framework/src/test/java/org/tron/core/zksnark/SendCoinShieldTest.java
@@ -90,7 +90,7 @@
 import org.tron.protos.contract.ShieldContract.SpendDescription;
 
 @Slf4j
-public class SendCoinShieldTest extends BaseTest {
+public class SendCoinShieldTest extends ZkSnarkTest {
 
   public static final long totalBalance = 1000_0000_000_000L;
   private static final byte[] DEFAULT_OVK;
@@ -119,11 +119,6 @@ public class SendCoinShieldTest extends BaseTest {
         .fromHexString("030c8c2bc59fb3eb8afb047a8ea4b028743d23e7d38c6fa30908358431e2314d");
   }
 
-  @BeforeClass
-  public static void initZksnarkParams() {
-    ZksnarkInitService.librustzcashInitZksnarkParams();
-  }
-
   /**
    * Init data.
    */
diff --git a/framework/src/test/java/org/tron/core/zksnark/ShieldedReceiveTest.java b/framework/src/test/java/org/tron/core/zksnark/ShieldedReceiveTest.java
@@ -103,7 +103,7 @@
 import org.tron.protos.contract.ShieldContract.SpendDescription;
 
 @Slf4j
-public class ShieldedReceiveTest extends BaseTest {
+public class ShieldedReceiveTest extends ZkSnarkTest {
 
   private static final String FROM_ADDRESS;
   private static final String ADDRESS_ONE_PRIVATE_KEY;
@@ -133,11 +133,6 @@ public class ShieldedReceiveTest extends BaseTest {
     FROM_ADDRESS = getHexAddressByPrivateKey(ADDRESS_ONE_PRIVATE_KEY);
   }
 
-  @BeforeClass
-  public static void initZksnarkParams() {
-    ZksnarkInitService.librustzcashInitZksnarkParams();
-  }
-
   /**
    * Init data.
    */
diff --git a/framework/src/test/java/org/tron/core/zksnark/ZkSnarkTest.java b/framework/src/test/java/org/tron/core/zksnark/ZkSnarkTest.java
@@ -0,0 +1,34 @@
+package org.tron.core.zksnark;
+
+import lombok.extern.slf4j.Slf4j;
+import org.junit.BeforeClass;
+import org.tron.common.BaseTest;
+import org.tron.core.zen.ZksnarkInitService;
+
+@Slf4j
+public abstract class ZkSnarkTest extends BaseTest {
+
+  private static boolean zkSnarkParamsInitialized = false;
+
+  @BeforeClass
+  public static void initOnce() {
+    if (!zkSnarkParamsInitialized) {
+      synchronized (ZkSnarkTest.class) {
+        if (!zkSnarkParamsInitialized) {
+          try {
+            ZksnarkInitService.librustzcashInitZksnarkParams();
+            logger.info("global zk params initialized");
+            zkSnarkParamsInitialized = true;
+          } catch (Exception e) {
+            logger.error("Failed to initialize zkSnark parameters", e);
+            throw e;
+          }
+        } else {
+          logger.info("global zk params already initialized");
+        }
+      }
+    } else {
+      logger.info("global zk params already initialized");
+    }
+  }
+}
