feat(approving): convert the approving window configuration to chain governance

Author: lxcmyf

actuator/src/main/java/org/tron/core/actuator/ProposalCreateActuator.java

@@ -3,6 +3,7 @@
 import static org.tron.core.actuator.ActuatorConstant.ACCOUNT_EXCEPTION_STR;
 import static org.tron.core.actuator.ActuatorConstant.NOT_EXIST_STR;
 import static org.tron.core.actuator.ActuatorConstant.WITNESS_EXCEPTION_STR;
+import static org.tron.core.config.Parameter.ChainConstant.BLOCK_PRODUCED_INTERVAL;
 
 import com.google.protobuf.ByteString;
 import com.google.protobuf.InvalidProtocolBufferException;
@@ -53,7 +54,8 @@ public boolean execute(Object result) throws ContractExeException {
 
       long currentMaintenanceTime =
           chainBaseManager.getDynamicPropertiesStore().getNextMaintenanceTime();
-      long now3 = now + CommonParameter.getInstance().getProposalExpireTime();
+      long now3 = now
+          + chainBaseManager.getDynamicPropertiesStore().getProposalVotingWindow() * BLOCK_PRODUCED_INTERVAL;
       long round = (now3 - currentMaintenanceTime) / maintenanceTimeInterval;
       long expirationTime =
           currentMaintenanceTime + (round + 1) * maintenanceTimeInterval;

actuator/src/main/java/org/tron/core/utils/ProposalUtil.java

@@ -4,6 +4,8 @@
 import static org.tron.core.Constant.CREATE_ACCOUNT_TRANSACTION_MIN_BYTE_SIZE;
 import static org.tron.core.Constant.DYNAMIC_ENERGY_INCREASE_FACTOR_RANGE;
 import static org.tron.core.Constant.DYNAMIC_ENERGY_MAX_FACTOR_RANGE;
+import static org.tron.core.Constant.MAX_PROPOSAL_VOTING_WINDOW;
+import static org.tron.core.Constant.MIN_PROPOSAL_VOTING_WINDOW;
 import static org.tron.core.config.Parameter.ChainConstant.ONE_YEAR_BLOCK_NUMBERS;
 
 import org.tron.common.utils.ForkController;
@@ -839,6 +841,20 @@ public static void validator(DynamicPropertiesStore dynamicPropertiesStore,
         }
         break;
       }
+      case PROPOSAL_VOTING_WINDOW: {
+        if (!forkController.pass(ForkBlockVersionEnum.VERSION_4_8_1)) {
+          throw new ContractValidateException(
+              "Bad chain parameter id [PROPOSAL_VOTING_WINDOW]");
+        }
+        if (value < MIN_PROPOSAL_VOTING_WINDOW
+            || value > MAX_PROPOSAL_VOTING_WINDOW) {
+          throw new ContractValidateException(
+              "This value[PROPOSAL_VOTING_WINDOW] is only allowed to be greater than or equal "
+                  + "to " + MIN_PROPOSAL_VOTING_WINDOW + " and less than or equal to "
+                  + MAX_PROPOSAL_VOTING_WINDOW + "!");
+        }
+        break;
+      }
       default:
         break;
     }
@@ -921,7 +937,8 @@ public enum ProposalType {         // current value, value range
     ALLOW_TVM_CANCUN(83), // 0, 1
     ALLOW_STRICT_MATH(87), // 0, 1
     CONSENSUS_LOGIC_OPTIMIZATION(88), // 0, 1
-    ALLOW_TVM_BLOB(89); // 0, 1
+    ALLOW_TVM_BLOB(89), // 0, 1
+    PROPOSAL_VOTING_WINDOW(92); // (86400, 201600]
 
     private long code;
 

chainbase/src/main/java/org/tron/core/store/DynamicPropertiesStore.java

@@ -1,6 +1,7 @@
 package org.tron.core.store;
 
 import static org.tron.common.math.Maths.max;
+import static org.tron.core.Constant.MIN_PROPOSAL_VOTING_WINDOW;
 import static org.tron.core.config.Parameter.ChainConstant.BLOCK_PRODUCED_INTERVAL;
 import static org.tron.core.config.Parameter.ChainConstant.DELEGATE_PERIOD;
 
@@ -231,6 +232,7 @@ public class DynamicPropertiesStore extends TronStoreWithRevoking<BytesCapsule>
   private static final byte[] ALLOW_TVM_CANCUN = "ALLOW_TVM_CANCUN".getBytes();
 
   private static final byte[] ALLOW_TVM_BLOB = "ALLOW_TVM_BLOB".getBytes();
+  private static final byte[] PROPOSAL_VOTING_WINDOW = "PROPOSAL_VOTING_WINDOW".getBytes();
 
   @Autowired
   private DynamicPropertiesStore(@Value("properties") String dbName) {
@@ -2946,6 +2948,21 @@ public long getAllowTvmBlob() {
         .orElse(CommonParameter.getInstance().getAllowTvmBlob());
   }
 
+  public void saveProposalVotingWindow(long proposalVotingWindow) {
+    this.put(PROPOSAL_VOTING_WINDOW, new BytesCapsule(ByteArray.fromLong(proposalVotingWindow)));
+  }
+
+  public long getProposalVotingWindow() {
+    return Optional.ofNullable(getUnchecked(PROPOSAL_VOTING_WINDOW))
+        .map(BytesCapsule::getData)
+        .map(ByteArray::toLong)
+        .orElse(CommonParameter.getInstance().getProposalVotingWindow());
+  }
+
+  public boolean supportProposalVotingWindow() {
+    return getProposalVotingWindow() > MIN_PROPOSAL_VOTING_WINDOW;
+  }
+
   private static class DynamicResourceProperties {
 
     private static final byte[] ONE_DAY_NET_LIMIT = "ONE_DAY_NET_LIMIT".getBytes();

common/src/main/java/org/tron/common/parameter/CommonParameter.java

@@ -724,6 +724,10 @@ public class CommonParameter {
   @Setter
   public long allowTvmBlob;
 
+  @Getter
+  @Setter
+  public long proposalVotingWindow = 86400L;
+
   private static double calcMaxTimeRatio() {
     //return max(2.0, min(5.0, 5 * 4.0 / max(Runtime.getRuntime().availableProcessors(), 1)));
     return 5.0;

common/src/main/java/org/tron/core/Constant.java

@@ -39,6 +39,8 @@ public class Constant {
   public static final long MAX_CONTRACT_RESULT_SIZE = 2L;
   public static final long PB_DEFAULT_ENERGY_LIMIT = 0L;
   public static final long CREATOR_DEFAULT_ENERGY_LIMIT = 1000 * 10_000L;
+  public static final long MIN_PROPOSAL_VOTING_WINDOW = 86400L; // Number of blocks to 3 days
+  public static final long MAX_PROPOSAL_VOTING_WINDOW = 201600L; // Number of blocks to 7 days
 
 
   // Numbers

common/src/main/java/org/tron/core/config/Parameter.java

@@ -26,7 +26,8 @@ public enum ForkBlockVersionEnum {
     VERSION_4_7_4(29, 1596780000000L, 80),
     VERSION_4_7_5(30, 1596780000000L, 80),
     VERSION_4_7_7(31, 1596780000000L, 80),
-    VERSION_4_8_0(32, 1596780000000L, 80);
+    VERSION_4_8_0(32, 1596780000000L, 80),
+    VERSION_4_8_1(33, 1596780000000L, 80);
     // if add a version, modify BLOCK_VERSION simultaneously
 
     @Getter
@@ -75,7 +76,7 @@ public class ChainConstant {
     public static final int SINGLE_REPEAT = 1;
     public static final int BLOCK_FILLED_SLOTS_NUMBER = 128;
     public static final int MAX_FROZEN_NUMBER = 1;
-    public static final int BLOCK_VERSION = 32;
+    public static final int BLOCK_VERSION = 33;
     public static final long FROZEN_PERIOD = 86_400_000L;
     public static final long DELEGATE_PERIOD = 3 * 86_400_000L;
     public static final long TRX_PRECISION = 1000_000L;

framework/src/main/java/org/tron/core/Wallet.java

@@ -1387,6 +1387,11 @@ public Protocol.ChainParameters getChainParameters() {
         .setValue(dbManager.getDynamicPropertiesStore().getAllowTvmBlob())
         .build());
 
+    builder.addChainParameter(Protocol.ChainParameters.ChainParameter.newBuilder()
+        .setKey("getProposalVotingWindow")
+        .setValue(dbManager.getDynamicPropertiesStore().getProposalVotingWindow())
+        .build());
+
     return builder.build();
   }
 

framework/src/main/java/org/tron/core/consensus/ProposalService.java

@@ -384,6 +384,10 @@ public static boolean process(Manager manager, ProposalCapsule proposalCapsule)
           manager.getDynamicPropertiesStore().saveAllowTvmBlob(entry.getValue());
           break;
         }
+        case PROPOSAL_VOTING_WINDOW: {
+          manager.getDynamicPropertiesStore().saveProposalVotingWindow(entry.getValue());
+          break;
+        }
         default:
           find = false;
           break;

framework/src/test/java/org/tron/common/ParameterTest.java

@@ -316,5 +316,7 @@ public void testCommonParameter() {
     assertEquals(1, parameter.getAllowEnergyAdjustment());
     parameter.setMaxCreateAccountTxSize(1000);
     assertEquals(1000, parameter.getMaxCreateAccountTxSize());
+    parameter.setProposalVotingWindow(86400L);
+    assertEquals(86400L, parameter.getProposalVotingWindow());
   }
 }

framework/src/test/java/org/tron/core/services/ProposalServiceTest.java

@@ -1,7 +1,10 @@
 package org.tron.core.services;
 
+import static org.tron.core.Constant.MAX_PROPOSAL_VOTING_WINDOW;
+import static org.tron.core.Constant.MIN_PROPOSAL_VOTING_WINDOW;
 import static org.tron.core.utils.ProposalUtil.ProposalType.CONSENSUS_LOGIC_OPTIMIZATION;
 import static org.tron.core.utils.ProposalUtil.ProposalType.ENERGY_FEE;
+import static org.tron.core.utils.ProposalUtil.ProposalType.PROPOSAL_VOTING_WINDOW;
 import static org.tron.core.utils.ProposalUtil.ProposalType.TRANSACTION_FEE;
 import static org.tron.core.utils.ProposalUtil.ProposalType.WITNESS_127_PAY_PER_BLOCK;
 
@@ -131,4 +134,23 @@ public void testUpdateConsensusLogicOptimization() {
     Assert.assertTrue(dbManager.getDynamicPropertiesStore().disableJavaLangMath());
   }
 
+  @Test
+  public void testProposalVotingWindow() {
+    long defaultWindow = dbManager.getDynamicPropertiesStore().getProposalVotingWindow();
+    Assert.assertEquals(MIN_PROPOSAL_VOTING_WINDOW, defaultWindow);
+    Assert.assertFalse(dbManager.getDynamicPropertiesStore().supportProposalVotingWindow());
+
+    Proposal proposal = Proposal.newBuilder().putParameters(PROPOSAL_VOTING_WINDOW.getCode(),
+        MAX_PROPOSAL_VOTING_WINDOW).build();
+    ProposalCapsule proposalCapsule = new ProposalCapsule(proposal);
+    proposalCapsule.setExpirationTime(1627279200000L);
+    boolean result = ProposalService.process(dbManager, proposalCapsule);
+    Assert.assertTrue(result);
+
+    long window = dbManager.getDynamicPropertiesStore().getProposalVotingWindow();
+    Assert.assertEquals(MAX_PROPOSAL_VOTING_WINDOW, window);
+
+    Assert.assertTrue(dbManager.getDynamicPropertiesStore().supportProposalVotingWindow());
+  }
+
 }