Skip to content

Commit f3b8caf

Browse files
Little-Peonyclaude
andcommitted
fix(test): restore BackupServerTest to original intent with members and sleep
Keep backupMembers configured so initServer() actually starts the server, preserving the test's original purpose of verifying start+close lifecycle. Thread.sleep(1000) ensures channel is assigned before @after tearDown() calls close(), avoiding the race. BackupServer.java is already reverted to develop original so no production code is changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent deb1058 commit f3b8caf

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

framework/src/test/java/org/tron/common/backup/BackupServerTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.tron.common.backup;
22

3+
import java.util.ArrayList;
4+
import java.util.List;
35
import org.junit.After;
46
import org.junit.Before;
57
import org.junit.Rule;
@@ -27,6 +29,9 @@ public void setUp() throws Exception {
2729
Args.setParam(new String[]{"-d", temporaryFolder.newFolder().toString()},
2830
TestConstants.TEST_CONF);
2931
CommonParameter.getInstance().setBackupPort(PublicMethod.chooseRandomPort());
32+
List<String> members = new ArrayList<>();
33+
members.add("127.0.0.2");
34+
CommonParameter.getInstance().setBackupMembers(members);
3035
BackupManager backupManager = new BackupManager();
3136
backupManager.init();
3237
backupServer = new BackupServer(backupManager);
@@ -38,9 +43,10 @@ public void tearDown() {
3843
Args.clearParam();
3944
}
4045

41-
@Test
42-
public void test() {
43-
// backupMembers is empty so initServer() is a no-op; verify close() is safe
46+
@Test(timeout = 60_000)
47+
public void test() throws InterruptedException {
4448
backupServer.initServer();
49+
// wait for the server to start so channel is assigned before close() is called
50+
Thread.sleep(1000);
4551
}
4652
}

0 commit comments

Comments
 (0)