fix(monitoring): rename function to coexist with upstream features.metrics fix

Upstream c355bca added ensureMetricsEnabled() for features.metrics=true,
deliberately a SAFE NO-OP on templates without a prometheus block
(nile/private — tracked in upstream issue #167) so it never synthesises
into those templates.

Our monitoring path needs the opposite behaviour: when monitoring.enabled
is true, we must actively synthesise the prometheus block on nile/private
(otherwise java-tron never exposes 9527 and Grafana stays empty on
private networks — the most common monitoring use-case).

Rename our function to ensureMetricsForMonitoring() so both behaviours
coexist without changing upstream's contract. Once upstream resolves
#167 by adding a prometheus block to nile/private templates, the two
functions can be merged in a follow-up.

Author: warku123

internal/render/hocon.go

@@ -46,7 +46,7 @@ func RenderHOCON(templateDir string, i *intent.Intent, node *intent.NodeSpec) (s
 
 	// Monitoring: auto-enable prometheus metrics in HOCON.
 	if i.Monitoring != nil && i.Monitoring.Enabled != nil && *i.Monitoring.Enabled {
-		config = ensureMetricsEnabled(config)
+		config = ensureMetricsForMonitoring(config)
 	}
 
 	// 2. Trailing override block (network_overrides + witness_key + config_overrides).
@@ -482,12 +482,19 @@ func ensureJSONRPCEnabled(config string) string {
 	return config
 }
 
-// ensureMetricsEnabled sets node.metrics.prometheus.enable = true in the HOCON
-// config. It handles three cases:
+// ensureMetricsForMonitoring sets node.metrics.prometheus.enable = true in
+// the HOCON config, synthesising the surrounding blocks when missing. This
+// is the active form used when monitoring.enabled=true — the user has
+// explicitly opted in to monitoring, so we *do* want to inject a prometheus
+// block into templates (nile/private) that lack one. Compare the simpler
+// SAFE NO-OP variant `ensureMetricsEnabled` used by features.metrics, which
+// only flips an existing flag and never synthesises blocks.
+//
+// Three cases:
 //  1. node.metrics { prometheus { enable = false } } → set to true
 //  2. node.metrics { prometheus { ... } } (no enable) → insert enable = true
 //  3. node.metrics block missing entirely → append a new block
-func ensureMetricsEnabled(config string) string {
+func ensureMetricsForMonitoring(config string) string {
 	lines := strings.Split(config, "\n")
 	inMetrics := false
 	inPrometheus := false

internal/render/hocon_test.go

@@ -286,44 +286,44 @@ func TestReplaceHOCONValue(t *testing.T) {
 	}
 }
 
-func TestEnsureMetricsEnabled_ExistingEnableFalse(t *testing.T) {
+func TestEnsureMetricsForMonitoring_ExistingEnableFalse(t *testing.T) {
 	in := `node.metrics {
   prometheus {
     enable = false
     port = 9527
   }
 }`
-	out := ensureMetricsEnabled(in)
+	out := ensureMetricsForMonitoring(in)
 	if !strings.Contains(out, "enable = true") {
 		t.Errorf("expected enable = true, got:\n%s", out)
 	}
 }
 
-func TestEnsureMetricsEnabled_NoEnableField(t *testing.T) {
+func TestEnsureMetricsForMonitoring_NoEnableField(t *testing.T) {
 	in := `node.metrics {
   prometheus {
     port = 9527
   }
 }`
-	out := ensureMetricsEnabled(in)
+	out := ensureMetricsForMonitoring(in)
 	if !strings.Contains(out, "enable = true") {
 		t.Errorf("expected enable = true inserted, got:\n%s", out)
 	}
 }
 
-func TestEnsureMetricsEnabled_NoPrometheusBlock(t *testing.T) {
+func TestEnsureMetricsForMonitoring_NoPrometheusBlock(t *testing.T) {
 	in := `node.metrics {
   something = else
 }`
-	out := ensureMetricsEnabled(in)
+	out := ensureMetricsForMonitoring(in)
 	if !strings.Contains(out, "prometheus {") || !strings.Contains(out, "enable = true") {
 		t.Errorf("expected prometheus block inserted, got:\n%s", out)
 	}
 }
 
-func TestEnsureMetricsEnabled_MissingMetricsBlock(t *testing.T) {
+func TestEnsureMetricsForMonitoring_MissingMetricsBlock(t *testing.T) {
 	in := `some.config = value`
-	out := ensureMetricsEnabled(in)
+	out := ensureMetricsForMonitoring(in)
 	if !strings.Contains(out, "node.metrics {") || !strings.Contains(out, "prometheus {") {
 		t.Errorf("expected full metrics block appended, got:\n%s", out)
 	}