You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-7Lines changed: 5 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -7,11 +7,6 @@ This document aims to provide you with a detailed contribution guide to help you
7
7
Please read this guide carefully before contributing and make sure to follow the rules here.
8
8
We look forward to working with you to make this project better together!
9
9
10
-
## Becoming a contributor
11
-
12
-
The first step is registering as a tRPC-Cpp contributor.
13
-
Before sending your first change to the tRPC-Cpp project you must have [signed and submitted a CLA (Contributor License Agreement)](to-do).
14
-
15
10
## Before contributing code
16
11
17
12
The project welcomes code patches, but to make sure things are well coordinated you should discuss any significant change before starting the work.
@@ -43,12 +38,15 @@ When opening an issue, make sure to answer these five questions:
43
38
4. What did you expect to see?
44
39
5. What did you see instead?
45
40
46
-
For change proposals, see Proposing Changes To [tRPC-Proposals](to-do).
41
+
For change proposals, see Proposing Changes To [tRPC-Proposals](https://github.com/trpc-group/trpc/blob/main/proposal/README.md).
47
42
48
43
## Contributing code
49
44
50
45
Follow the [GitHub flow](https://docs.github.com/en/get-started/quickstart/github-flow) to [create a GitHub pull request](https://docs.github.com/en/get-started/quickstart/github-flow#create-a-pull-request).
51
46
47
+
If this is your first time submitting a PR to the tRPC project, you will be reminded in the "Conversation" tab of the PR to sign and submit the [Contributor License Agreement](https://github.com/trpc-group/cla-database/blob/main/Tencent-Contributor-License-Agreement.md).
48
+
Only when you have signed the Contributor License Agreement, your submitted PR has the possibility of being accepted.
49
+
52
50
Some things to keep in mind:
53
51
- Ensure that your code conforms to the project's code specifications.
54
52
This includes but is not limited to code style, comment specifications, etc. This helps us to maintain the cleanliness and consistency of the project.
@@ -105,7 +103,7 @@ When this change is eventually applied, the issue tracker will automatically mar
105
103
### Copyright headers
106
104
107
105
Files in the tRPC-Cpp repository don't list author names, both to avoid clutter and to avoid having to keep the lists up to date.
108
-
Instead, your name will appear in the [change log](todo).
106
+
Instead, your name will appear in the change log.
109
107
110
108
New files that you contribute should use the standard copyright header:
0 commit comments