Commit 1dea63f
committed
examples: align code-review fixtures + detectors to official scenarios
The issue's deliverables require 8 sample diffs covering specific
scenarios and rule coverage across all 6 categories. Rework fixtures to:
clean, security, async_resource_leak, db_lifecycle, missing_tests,
duplicate_finding, sandbox_failure, secret_redaction.
Add two detectors that bandit/ruff don't provide:
db_lifecycle: a DB connection/cursor opened without with and never
closed (content heuristic, mirrored in the sandbox run_checks.py).
missing_tests: source changed with no corresponding test change
(diff-level; added in the engine for every runtime).
Enable ruff's flake8-bandit (S) rules so os.system is flagged by both
bandit (B605) and ruff (S605), giving a genuine duplicate the dedup
stage collapses. Suppress assert-used (B101/S101) noise.
selftest now scores the 8 official-scenario fixtures (100%/0% on the
proxy set); adds scenario tests for db_lifecycle, missing_tests,
duplicate collapse, sandbox-failure, and all-6-categories.
Updates #92
RELEASE NOTES: NONE1 parent 04f3969 commit 1dea63f
18 files changed
Lines changed: 269 additions & 104 deletions
File tree
- examples/skills_code_review_agent
- fixtures
- diffs
- expected
- pipeline
- skills/code-review/scripts
- tests/examples
Lines changed: 0 additions & 18 deletions
This file was deleted.
Lines changed: 0 additions & 9 deletions
This file was deleted.
Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 0 additions & 10 deletions
This file was deleted.
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments