fix(examples): tidy store imports and cover all redaction write paths in tests

Author: DNKYr

examples/skills_code_review_agent/storage/store.py

@@ -5,6 +5,7 @@
 # tRPC-Agent-Python is licensed under Apache-2.0.
 """ReviewStore: persistence built on the SDK's SqlStorage (SQLite by default,
 any SQLAlchemy db_url works)."""
+import uuid
 from datetime import datetime
 
 from trpc_agent_sdk.storage import SqlCondition, SqlKey, SqlStorage
@@ -38,7 +39,6 @@ async def create_task(self, input_type: str, input_ref: str, runtime: str,
                             runtime=runtime, dry_run=dry_run, status="running")
         task_id = row.id or ""
         if not task_id:
-            import uuid
             task_id = uuid.uuid4().hex
             row.id = task_id
         await self._add(row)

examples/skills_code_review_agent/tests/test_store.py

@@ -8,12 +8,12 @@
 from storage.store import ReviewStore
 
 
-async def _new_store(tmp_path):
+def _new_store(tmp_path):
     return ReviewStore(db_url=f"sqlite:///{tmp_path}/cr.db")
 
 
 async def test_task_roundtrip(tmp_path):
-    store = await _new_store(tmp_path)
+    store = _new_store(tmp_path)
     task_id = await store.create_task("fixture", "clean.diff", "local", True)
     assert task_id
     await store.update_task(task_id, status="completed",
@@ -26,7 +26,7 @@ async def test_task_roundtrip(tmp_path):
 
 
 async def test_bundle_collects_all_tables(tmp_path):
-    store = await _new_store(tmp_path)
+    store = _new_store(tmp_path)
     task_id = await store.create_task("fixture", "x.diff", "local", True)
     await store.add_sandbox_run(task_id, script="check_security.py", category="security",
                                 status="ok", exit_code=0, duration_ms=12, timed_out=False,
@@ -51,23 +51,30 @@ async def test_bundle_collects_all_tables(tmp_path):
 
 
 async def test_store_redacts_evidence_and_output(tmp_path):
-    store = await _new_store(tmp_path)
+    store = _new_store(tmp_path)
     task_id = await store.create_task("fixture", "x.diff", "local", True)
     secret = "sk-abcdefghijklmnopqrstuvwxyz123456"
     await store.add_findings(task_id, [Finding(
         severity="critical", category="secret_leak", file="a.py", line=3,
         title="secret", evidence=f'key = "{secret}"', confidence=0.95)], status="reported")
     await store.add_sandbox_run(task_id, script="s.py", category="c", status="ok",
                                 exit_code=0, duration_ms=1, timed_out=False,
-                                stdout_summary=f"leaked {secret}", stderr_summary="", error_type="")
+                                stdout_summary=f"leaked {secret}",
+                                stderr_summary=f"stderr leaked {secret}", error_type="")
+    await store.add_filter_event(task_id, target=f"/path/{secret}/config",
+                                 decision="deny", rule="risk_secret", reason="file contains secret")
+    await store.add_report(task_id, {"conclusion": "blocked"}, f"# Report\nSecret was: {secret}")
     bundle = await store.get_task_bundle(task_id)
     assert secret not in bundle["findings"][0]["evidence"]
     assert secret not in bundle["sandbox_runs"][0]["stdout_summary"]
+    assert secret not in bundle["sandbox_runs"][0]["stderr_summary"]
+    assert secret not in bundle["filter_events"][0]["target"]
+    assert secret not in bundle["report"]["report_md"]
     await store.close()
 
 
 async def test_unknown_task_returns_none_task(tmp_path):
-    store = await _new_store(tmp_path)
+    store = _new_store(tmp_path)
     bundle = await store.get_task_bundle("nope")
     assert bundle["task"] is None
     await store.close()