fix(safety): detect GNU rm long options --recursive/--force (CongkeChen review #5)

CongkeChen review on 9edfacd: _DELETE_PATTERNS only matched short options (-rf), so 'rm --recursive --force /' bypassed R001. Add two patterns: one for rm directly followed by --recursive/--force, one for rm with a preceding option then --recursive/--force. Covers --recursive, --force, --recursive --force, --force --recursive, --recursive -f, -r --force, and --recursive=yes (GNU --opt=val form). 'rm file.txt' still correctly not flagged. Add regression test test_dangerous_files_bash_rm_gnu_long_options.

Author: Violet2314

tests/tool_safety/test_rules.py

@@ -36,6 +36,26 @@ def test_dangerous_files_bash_rm_rf():
     assert any("R001" in f.rule_id for f in findings)
 
 
+def test_dangerous_files_bash_rm_gnu_long_options():
+    """Regression for CongkeChen review: rm --recursive / --force must not bypass R001.
+
+    GNU rm supports --recursive/--force long options. The original _DELETE_PATTERNS
+    only matched short options (-rf), so 'rm --recursive --force /' was missed.
+    """
+    rule = DangerousFilesRule()
+    for cmd in (
+        "rm --recursive /",
+        "rm --force /",
+        "rm --recursive --force /",
+        "rm --force --recursive /",
+        "rm --recursive -f /",
+        "rm -r --force /",
+        "rm --recursive=yes /",
+    ):
+        findings = rule.check(ScanInput(script=cmd, language="bash"), _policy())
+        assert any("R001" in f.rule_id for f in findings), f"failed to flag: {cmd!r}"
+
+
 def test_dangerous_files_read_ssh_key():
     rule = DangerousFilesRule()
     inp = ScanInput(script="open('/home/u/.ssh/id_rsa')", language="python")

trpc_agent_sdk/safety/_rules.py

@@ -93,6 +93,10 @@ def _finding(
 _DELETE_PATTERNS = [
     re.compile(r"\brm\s+(-[a-zA-Z]*r[a-zA-Z]*f?|-[a-zA-Z]*f[a-zA-Z]*r?)\b", re.IGNORECASE),
     re.compile(r"\brm\s+-rf\b", re.IGNORECASE),
+    # GNU long options: catch rm with --recursive or --force anywhere in its args.
+    # Matches "rm --recursive /", "rm --force --recursive /", "rm -r --force /", etc.
+    re.compile(r"\brm\s+(?:-[a-zA-Z]+|--[a-z]+)\s+.*--(?:recursive|force)\b", re.IGNORECASE),
+    re.compile(r"\brm\s+--(?:recursive|force)\b", re.IGNORECASE),
     re.compile(r"\brmdir\s+/s\b", re.IGNORECASE),
     re.compile(r"\bdel\s+/[sq]\b", re.IGNORECASE),
     re.compile(r"\bfind\b.*(-delete|-exec\s+rm\b)", re.IGNORECASE),