feat(examples): add finding model with dedup and confidence gating

Author: DNKYr

examples/skills_code_review_agent/review/findings.py

@@ -0,0 +1,68 @@
+# Tencent is pleased to support the open source community by making tRPC-Agent-Python available.
+#
+# Copyright (C) 2026 Tencent. All rights reserved.
+#
+# tRPC-Agent-Python is licensed under Apache-2.0.
+"""Finding model plus dedup and confidence-gating helpers."""
+from pydantic import BaseModel
+
+SEVERITY_ORDER = {"critical": 4, "high": 3, "medium": 2, "low": 1, "info": 0}
+CONFIDENCE_THRESHOLD = 0.6
+
+
+class Finding(BaseModel):
+    """One structured review finding."""
+
+    severity: str
+    category: str
+    file: str
+    line: int
+    title: str
+    evidence: str = ""
+    recommendation: str = ""
+    confidence: float = 1.0
+    source: str = "static"
+
+    @property
+    def dedup_key(self) -> str:
+        return f"{self.file}:{self.line}:{self.category}"
+
+
+def _merge(winner: Finding, loser: Finding) -> Finding:
+    update = {}
+    if SEVERITY_ORDER.get(loser.severity, 0) > SEVERITY_ORDER.get(winner.severity, 0):
+        update["severity"] = loser.severity
+    if loser.confidence > winner.confidence:
+        update["confidence"] = loser.confidence
+    if loser.source != winner.source:
+        update["source"] = "static+llm"
+    return winner.model_copy(update=update) if update else winner
+
+
+def dedupe(findings):
+    """Collapse findings sharing (file, line, category). Returns (kept, dropped)."""
+    kept: dict[str, Finding] = {}
+    dropped = []
+    for f in findings:
+        cur = kept.get(f.dedup_key)
+        if cur is None:
+            kept[f.dedup_key] = f
+        else:
+            kept[f.dedup_key] = _merge(cur, f)
+            dropped.append(f)
+    return list(kept.values()), dropped
+
+
+def gate(findings, threshold: float = CONFIDENCE_THRESHOLD):
+    """Split into (reported, needs_human_review) by confidence."""
+    reported = [f for f in findings if f.confidence >= threshold]
+    needs = [f for f in findings if f.confidence < threshold]
+    return reported, needs
+
+
+def severity_distribution(findings):
+    """Count findings per severity."""
+    dist: dict[str, int] = {}
+    for f in findings:
+        dist[f.severity] = dist.get(f.severity, 0) + 1
+    return dist

examples/skills_code_review_agent/tests/test_findings.py

@@ -0,0 +1,45 @@
+# Tencent is pleased to support the open source community by making tRPC-Agent-Python available.
+#
+# Copyright (C) 2026 Tencent. All rights reserved.
+#
+# tRPC-Agent-Python is licensed under Apache-2.0.
+"""Tests for the Finding model, dedup and confidence gating."""
+from review.findings import Finding, dedupe, gate, severity_distribution
+
+
+def make(severity="high", category="security", file="a.py", line=1,
+         confidence=0.9, source="static", title="t"):
+    return Finding(severity=severity, category=category, file=file, line=line,
+                   title=title, confidence=confidence, source=source)
+
+
+def test_dedup_same_file_line_category():
+    kept, dropped = dedupe([make(title="eval"), make(title="exec", confidence=0.8)])
+    assert len(kept) == 1 and len(dropped) == 1
+    assert kept[0].confidence == 0.9
+
+
+def test_dedup_merges_sources():
+    kept, _ = dedupe([make(source="static"), make(source="llm", confidence=0.7)])
+    assert kept[0].source == "static+llm"
+
+
+def test_dedup_keeps_highest_severity():
+    kept, _ = dedupe([make(severity="medium"), make(severity="critical", confidence=0.5)])
+    assert kept[0].severity == "critical"
+
+
+def test_no_dedup_across_lines():
+    kept, dropped = dedupe([make(line=1), make(line=2)])
+    assert len(kept) == 2 and dropped == []
+
+
+def test_gate_splits_low_confidence():
+    reported, needs = gate([make(confidence=0.9), make(line=2, confidence=0.5)])
+    assert len(reported) == 1 and len(needs) == 1
+    assert needs[0].confidence == 0.5
+
+
+def test_severity_distribution():
+    dist = severity_distribution([make(), make(line=2, severity="low")])
+    assert dist == {"high": 1, "low": 1}