Skip to content

feat(a2a): support optional app_name for TrpcA2aAgentService#131

Merged
weimch merged 1 commit into
trpc-group:mainfrom
yangenle6-alt:feature/a2a-service-app-name
Jul 7, 2026
Merged

feat(a2a): support optional app_name for TrpcA2aAgentService#131
weimch merged 1 commit into
trpc-group:mainfrom
yangenle6-alt:feature/a2a-service-app-name

Conversation

@yangenle6-alt

Copy link
Copy Markdown
Contributor

Allow the Runner's app identity to differ from the A2A service_name by adding an optional app_name parameter. Falls back to service_name when not provided, preserving existing behavior for all current callers.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yangenle6-alt

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@yangenle6-alt

Copy link
Copy Markdown
Contributor Author

recheck

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a547d6b). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             main        #131   +/-   ##
==========================================
  Coverage        ?   87.51591%           
==========================================
  Files           ?         467           
  Lines           ?       44008           
  Branches        ?           0           
==========================================
  Hits            ?       38514           
  Misses          ?        5494           
  Partials        ?           0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Allow the Runner's app identity to differ from the A2A service_name by
adding an optional app_name parameter. Falls back to service_name when
not provided, preserving existing behavior for all current callers.

Co-authored-by: Cursor <cursoragent@cursor.com>
@yangenle6-alt
yangenle6-alt force-pushed the feature/a2a-service-app-name branch from 7bc358a to ba36ee7 Compare July 7, 2026 03:12
Rook1ex added a commit to trpc-group/cla-database that referenced this pull request Jul 7, 2026

@weimch weimch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@weimch
weimch merged commit cbb6979 into trpc-group:main Jul 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants