BugFix: Fix the problem of occasional core dump in the Fiber TimerWorker when the program exits (#148)

Author: chhy2009

trpc/common/config/client_conf_parser.h

@@ -103,9 +103,13 @@ struct convert<trpc::ServiceProxyConfig> {
     if (node["recv_buffer_size"]) proxy_config.recv_buffer_size = node["recv_buffer_size"].as<uint32_t>();
     if (node["send_queue_capacity"]) proxy_config.send_queue_capacity = node["send_queue_capacity"].as<uint32_t>();
     if (node["send_queue_timeout"]) proxy_config.send_queue_timeout = node["send_queue_timeout"].as<uint32_t>();
-    if (node["endpoint_hash_bucket_size"]) proxy_config.endpoint_hash_bucket_size = node["endpoint_hash_bucket_size"].as<uint32_t>();
+    if (node["endpoint_hash_bucket_size"]) {
+      proxy_config.endpoint_hash_bucket_size = node["endpoint_hash_bucket_size"].as<uint32_t>();
+    }
     if (node["threadmodel_type"]) proxy_config.threadmodel_type = node["threadmodel_type"].as<std::string>();
-    if (node["threadmodel_instance_name"]) proxy_config.threadmodel_instance_name = node["threadmodel_instance_name"].as<std::string>();
+    if (node["threadmodel_instance_name"]) {
+      proxy_config.threadmodel_instance_name = node["threadmodel_instance_name"].as<std::string>();
+    }
     if (node["selector_name"]) proxy_config.selector_name = node["selector_name"].as<std::string>();
     if (node["namespace"]) proxy_config.namespace_ = node["namespace"].as<std::string>();
     if (node["load_balance_name"]) proxy_config.load_balance_name = node["load_balance_name"].as<std::string>();

trpc/runtime/threadmodel/fiber/detail/assembly.h

@@ -48,6 +48,7 @@ extern "C" {
 
 // FIXME: TSan support does not work yet.
 #ifdef TRPC_INTERNAL_USE_TSAN
+#ifndef TRPC_INTERNAL_EXCLUDE_TSAN_INTERFACE
 extern "C" {
 [[gnu::weak]] void* __tsan_get_current_fiber(void);
 [[gnu::weak]] void* __tsan_create_fiber(unsigned);
@@ -78,6 +79,7 @@ const unsigned __tsan_mutex_recursive_unlock = 1 << 7;
 [[gnu::weak]] void __tsan_acquire(void*);
 [[gnu::weak]] void __tsan_release(void*);
 }
+#endif
 
 #define TRPC_INTERNAL_TSAN_MUTEX_CREATE(...) __tsan_mutex_create(__VA_ARGS__)
 #define TRPC_INTERNAL_TSAN_MUTEX_DESTROY(...) __tsan_mutex_destroy(__VA_ARGS__)

trpc/runtime/threadmodel/fiber/fiber_thread_model.cc

@@ -129,16 +129,27 @@ void FiberThreadModel::Start() noexcept {
 }
 
 void FiberThreadModel::Terminate() noexcept {
+  // Exit the timer worker first due to it uses the tls variable of the FiberWorker thread.
   for (auto&& e : scheduling_groups_) {
     for (auto&& ee : e) {
       ee->timer_worker->Stop();
-      ee->scheduling_group->Stop();
     }
   }
 
   for (auto&& e : scheduling_groups_) {
     for (auto&& ee : e) {
       ee->timer_worker->Join();
+    }
+  }
+
+  for (auto&& e : scheduling_groups_) {
+    for (auto&& ee : e) {
+      ee->scheduling_group->Stop();
+    }
+  }
+
+  for (auto&& e : scheduling_groups_) {
+    for (auto&& ee : e) {
       for (auto&& eee : ee->fiber_workers) {
         eee->Join();
       }